Re: Review Request 38828: docker: containerizer: fixed double-closing of STDIN in error handling.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38828/#review100966
---

Ship it!


Ship It!

- Timothy Chen


On Sept. 29, 2015, 12:50 a.m., Chi Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38828/
> ---
> 
> (Updated Sept. 29, 2015, 12:50 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Bugs: mesos-3519
> https://issues.apache.org/jira/browse/mesos-3519
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The slave will destroy executors that are not launched successfully, which 
> will
> close all open file descriptors, thus the extra close is not needed.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp efa37266368ee12fea9134b35ebc5047a2820f94 
> 
> Diff: https://reviews.apache.org/r/38828/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Re: Review Request 38828: docker: containerizer: fixed double-closing of STDIN in error handling.

[Ben Mahler]

> On Sept. 29, 2015, 1:17 a.m., Timothy Chen wrote:
> > src/slave/containerizer/docker.cpp, lines 926-928
> > 
> >
> > Hey I think we should be doing the same behavior as MesosContainerizer 
> > since the executor behaves the same, and I think yes the extra close is not 
> > necessary.

Great, I'll get this committed then.


- Ben


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38828/#review100913
---


On Sept. 29, 2015, 12:50 a.m., Chi Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38828/
> ---
> 
> (Updated Sept. 29, 2015, 12:50 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Bugs: mesos-3519
> https://issues.apache.org/jira/browse/mesos-3519
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The slave will destroy executors that are not launched successfully, which 
> will
> close all open file descriptors, thus the extra close is not needed.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp efa37266368ee12fea9134b35ebc5047a2820f94 
> 
> Diff: https://reviews.apache.org/r/38828/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Re: Review Request 38828: docker: containerizer: fixed double-closing of STDIN in error handling.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38828/#review100908
---



src/slave/containerizer/docker.cpp 


I believe these were in place to terminate the subprocess, so perhaps a 
killtree with SIGTERM would be more appropriate to replace these with.. 
thoughts? Perhaps reach out to tim chen for this code.


- Ben Mahler


On Sept. 28, 2015, 10:50 p.m., Chi Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38828/
> ---
> 
> (Updated Sept. 28, 2015, 10:50 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: mesos-3519
> https://issues.apache.org/jira/browse/mesos-3519
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The slave will destroy executors that are not launched successfully, which 
> will
> close all open file descriptors, thus the extra close is not needed.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp efa37266368ee12fea9134b35ebc5047a2820f94 
> 
> Diff: https://reviews.apache.org/r/38828/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Re: Review Request 38828: docker: containerizer: fixed double-closing of STDIN in error handling.

[Chi Zhang]

> On Sept. 29, 2015, 12:31 a.m., Ben Mahler wrote:
> > src/slave/containerizer/docker.cpp, lines 926-928
> > 
> >
> > I believe these were in place to terminate the subprocess, so perhaps a 
> > killtree with SIGTERM would be more appropriate to replace these with.. 
> > thoughts? Perhaps reach out to tim chen for this code.

Yeah, I checked the mesos containerizer code, which in case just returns a 
failure and waits for the slave to issue destroy when it gets the failure, but 
I will pull Tim in.


- Chi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38828/#review100908
---


On Sept. 28, 2015, 10:50 p.m., Chi Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38828/
> ---
> 
> (Updated Sept. 28, 2015, 10:50 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: mesos-3519
> https://issues.apache.org/jira/browse/mesos-3519
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The slave will destroy executors that are not launched successfully, which 
> will
> close all open file descriptors, thus the extra close is not needed.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp efa37266368ee12fea9134b35ebc5047a2820f94 
> 
> Diff: https://reviews.apache.org/r/38828/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Re: Review Request 38828: docker: containerizer: fixed double-closing of STDIN in error handling.

[Chi Zhang]

> On Sept. 29, 2015, 12:31 a.m., Ben Mahler wrote:
> > src/slave/containerizer/docker.cpp, lines 926-928
> > 
> >
> > I believe these were in place to terminate the subprocess, so perhaps a 
> > killtree with SIGTERM would be more appropriate to replace these with.. 
> > thoughts? Perhaps reach out to tim chen for this code.
> 
> Chi Zhang wrote:
> Yeah, I checked the mesos containerizer code, which in case just returns 
> a failure and waits for the slave to issue destroy when it gets the failure, 
> but I will pull Tim in.

Hi Tim, could you take a look at this patch please?


- Chi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38828/#review100908
---


On Sept. 29, 2015, 12:50 a.m., Chi Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38828/
> ---
> 
> (Updated Sept. 29, 2015, 12:50 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Bugs: mesos-3519
> https://issues.apache.org/jira/browse/mesos-3519
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The slave will destroy executors that are not launched successfully, which 
> will
> close all open file descriptors, thus the extra close is not needed.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp efa37266368ee12fea9134b35ebc5047a2820f94 
> 
> Diff: https://reviews.apache.org/r/38828/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Re: Review Request 38828: docker: containerizer: fixed double-closing of STDIN in error handling.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38828/#review100913
---



src/slave/containerizer/docker.cpp 


Hey I think we should be doing the same behavior as MesosContainerizer 
since the executor behaves the same, and I think yes the extra close is not 
necessary.


- Timothy Chen


On Sept. 29, 2015, 12:50 a.m., Chi Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38828/
> ---
> 
> (Updated Sept. 29, 2015, 12:50 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Bugs: mesos-3519
> https://issues.apache.org/jira/browse/mesos-3519
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The slave will destroy executors that are not launched successfully, which 
> will
> close all open file descriptors, thus the extra close is not needed.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp efa37266368ee12fea9134b35ebc5047a2820f94 
> 
> Diff: https://reviews.apache.org/r/38828/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>