Re: Review Request 38858: Ensured that slave's work_dir is a shared mount in its own peer group when LinuxFilesystemIsolator is used.

2015-09-29 Thread Jiang Yan Xu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38858/#review101024
---

Ship it!


Modulo Ian's comments.


src/slave/containerizer/isolators/filesystem/linux.cpp (line 144)


s/group/groups/


- Jiang Yan Xu


On Sept. 29, 2015, 12:48 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38858/
> ---
> 
> (Updated Sept. 29, 2015, 12:48 p.m.)
> 
> 
> Review request for mesos, Timothy Chen and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3539
> https://issues.apache.org/jira/browse/MESOS-3539
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ensured that slave's work_dir is a shared mount in its own peer group when 
> LinuxFilesystemIsolator is used.
> 
> This addressed the TODO in the current code.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> 8fa929f12838044762be82287e1b714406d9 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> 41d098c7d66eba0befc3708c6660a6a3e5f0d2de 
> 
> Diff: https://reviews.apache.org/r/38858/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 38858: Ensured that slave's work_dir is a shared mount in its own peer group when LinuxFilesystemIsolator is used.

2015-09-29 Thread Ian Downes 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38858/#review101011
---



src/slave/containerizer/isolators/filesystem/linux.cpp (lines 88 - 94)


This has appeared in multiple places, perhaps refactor this into a helper?



src/slave/containerizer/isolators/filesystem/linux.cpp (line 121)


Suggestion, refactor to avoid the nesting?

if (workDirMount.isNone() {
  // mount it and get the fs::MountInfoTable::Entry
}

// Check it's a slave mount.

// Check it's a shared mount.



src/slave/containerizer/isolators/filesystem/linux.cpp (line 126)


If it's already mounted (so it's in /etc/mtab) there's no reason to shell 
out; you can use fs::mount().



src/slave/containerizer/isolators/filesystem/linux.cpp (line 146)


If it's already mounted (so it's in /etc/mtab) there's no reason to shell 
out; you can use fs::mount().



src/tests/containerizer/filesystem_isolator_tests.cpp (lines 926 - 930)


This doesn't verify the work_dir *is* bind mounted, just that *if* it is 
then it's a shared mount...



src/tests/containerizer/filesystem_isolator_tests.cpp (lines 949 - 953)


Ditto.


- Ian Downes


On Sept. 29, 2015, 12:48 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38858/
> ---
> 
> (Updated Sept. 29, 2015, 12:48 p.m.)
> 
> 
> Review request for mesos, Timothy Chen and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3539
> https://issues.apache.org/jira/browse/MESOS-3539
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ensured that slave's work_dir is a shared mount in its own peer group when 
> LinuxFilesystemIsolator is used.
> 
> This addressed the TODO in the current code.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> 8fa929f12838044762be82287e1b714406d9 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> 41d098c7d66eba0befc3708c6660a6a3e5f0d2de 
> 
> Diff: https://reviews.apache.org/r/38858/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 38858: Ensured that slave's work_dir is a shared mount in its own peer group when LinuxFilesystemIsolator is used.

2015-09-29 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38858/
---

(Updated Sept. 29, 2015, 11:13 p.m.)


Review request for mesos, Timothy Chen and Jiang Yan Xu.


Changes
---

Addressed review comments.


Bugs: MESOS-3539
https://issues.apache.org/jira/browse/MESOS-3539


Repository: mesos


Description
---

Ensured that slave's work_dir is a shared mount in its own peer group when 
LinuxFilesystemIsolator is used.

This addressed the TODO in the current code.


Diffs (updated)
-

  src/linux/fs.hpp f3aa0c2a385527eab5895f5d10c29e3d68e30a49 
  src/slave/containerizer/isolators/filesystem/linux.cpp 
8fa929f12838044762be82287e1b714406d9 
  src/tests/containerizer/filesystem_isolator_tests.cpp 
41d098c7d66eba0befc3708c6660a6a3e5f0d2de 

Diff: https://reviews.apache.org/r/38858/diff/


Testing
---

sudo make check


Thanks,

Jie Yu

Re: Review Request 38858: Ensured that slave's work_dir is a shared mount in its own peer group when LinuxFilesystemIsolator is used.

2015-09-29 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38858/#review101017
---


Patch looks great!

Reviews applied: [38855, 38858]

All tests passed.

- Mesos ReviewBot


On Sept. 29, 2015, 7:48 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38858/
> ---
> 
> (Updated Sept. 29, 2015, 7:48 p.m.)
> 
> 
> Review request for mesos, Timothy Chen and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3539
> https://issues.apache.org/jira/browse/MESOS-3539
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ensured that slave's work_dir is a shared mount in its own peer group when 
> LinuxFilesystemIsolator is used.
> 
> This addressed the TODO in the current code.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> 8fa929f12838044762be82287e1b714406d9 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> 41d098c7d66eba0befc3708c6660a6a3e5f0d2de 
> 
> Diff: https://reviews.apache.org/r/38858/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 38858: Ensured that slave's work_dir is a shared mount in its own peer group when LinuxFilesystemIsolator is used.

2015-09-29 Thread Jie Yu 


> On Sept. 29, 2015, 9:04 p.m., Ian Downes wrote:
> > src/slave/containerizer/isolators/filesystem/linux.cpp, line 126
> > 
> >
> > If it's already mounted (so it's in /etc/mtab) there's no reason to 
> > shell out; you can use fs::mount().

True, but given that we already shell out for the bind mount, I just want to be 
consistent.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38858/#review101011
---


On Sept. 29, 2015, 7:48 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38858/
> ---
> 
> (Updated Sept. 29, 2015, 7:48 p.m.)
> 
> 
> Review request for mesos, Timothy Chen and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3539
> https://issues.apache.org/jira/browse/MESOS-3539
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ensured that slave's work_dir is a shared mount in its own peer group when 
> LinuxFilesystemIsolator is used.
> 
> This addressed the TODO in the current code.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> 8fa929f12838044762be82287e1b714406d9 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> 41d098c7d66eba0befc3708c6660a6a3e5f0d2de 
> 
> Diff: https://reviews.apache.org/r/38858/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 38858: Ensured that slave's work_dir is a shared mount in its own peer group when LinuxFilesystemIsolator is used.

2015-09-29 Thread Jie Yu 


> On Sept. 29, 2015, 9:04 p.m., Ian Downes wrote:
> > src/tests/containerizer/filesystem_isolator_tests.cpp, lines 926-930
> > 
> >
> > This doesn't verify the work_dir *is* bind mounted, just that *if* it 
> > is then it's a shared mount...

We don't care if it is a bind mount or not. As long as its a shared mount in 
its own peer group, we are ok with that.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38858/#review101011
---


On Sept. 29, 2015, 7:48 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38858/
> ---
> 
> (Updated Sept. 29, 2015, 7:48 p.m.)
> 
> 
> Review request for mesos, Timothy Chen and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3539
> https://issues.apache.org/jira/browse/MESOS-3539
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ensured that slave's work_dir is a shared mount in its own peer group when 
> LinuxFilesystemIsolator is used.
> 
> This addressed the TODO in the current code.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> 8fa929f12838044762be82287e1b714406d9 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> 41d098c7d66eba0befc3708c6660a6a3e5f0d2de 
> 
> Diff: https://reviews.apache.org/r/38858/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 38858: Ensured that slave's work_dir is a shared mount in its own peer group when LinuxFilesystemIsolator is used.

2015-09-29 Thread Jie Yu 


> On Sept. 29, 2015, 9:04 p.m., Ian Downes wrote:
> > src/slave/containerizer/isolators/filesystem/linux.cpp, lines 88-94
> > 
> >
> > This has appeared in multiple places, perhaps refactor this into a 
> > helper?

Yeah, I think having a 'find' method for mount table sounds like a better 
solution. I'll add a TODO here.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38858/#review101011
---


On Sept. 29, 2015, 7:48 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38858/
> ---
> 
> (Updated Sept. 29, 2015, 7:48 p.m.)
> 
> 
> Review request for mesos, Timothy Chen and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3539
> https://issues.apache.org/jira/browse/MESOS-3539
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Ensured that slave's work_dir is a shared mount in its own peer group when 
> LinuxFilesystemIsolator is used.
> 
> This addressed the TODO in the current code.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> 8fa929f12838044762be82287e1b714406d9 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> 41d098c7d66eba0befc3708c6660a6a3e5f0d2de 
> 
> Diff: https://reviews.apache.org/r/38858/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 38858: Ensured that slave's work_dir is a shared mount in its own peer group when LinuxFilesystemIsolator is used.

2015-09-29 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38858/
---

(Updated Sept. 29, 2015, 7:48 p.m.)


Review request for mesos, Timothy Chen and Jiang Yan Xu.


Changes
---

Fixed a memory leak in the test.


Bugs: MESOS-3539
https://issues.apache.org/jira/browse/MESOS-3539


Repository: mesos


Description
---

Ensured that slave's work_dir is a shared mount in its own peer group when 
LinuxFilesystemIsolator is used.

This addressed the TODO in the current code.


Diffs (updated)
-

  src/slave/containerizer/isolators/filesystem/linux.cpp 
8fa929f12838044762be82287e1b714406d9 
  src/tests/containerizer/filesystem_isolator_tests.cpp 
41d098c7d66eba0befc3708c6660a6a3e5f0d2de 

Diff: https://reviews.apache.org/r/38858/diff/


Testing
---

sudo make check


Thanks,

Jie Yu