Re: Review Request 38967: Added functionality to generate Java V1 Protobufs and insert them into the existing JAR for now

2015-10-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38967/#review101392 --- Patch looks great! Reviews applied: [38967] All tests passed. -

Re: Review Request 38967: Added functionality to generate Java V1 Protobufs and insert them into the existing JAR for now

2015-10-02 Thread Anand Mazumdar
> On Oct. 2, 2015, 10:34 p.m., Isabel Jimenez wrote: > > src/Makefile.am, line 225 > > > > > > Could you also add a fix for v1 python proto generation? Checkout my comment here : https://issues.apache.org/jira/brows

Re: Review Request 38967: Added functionality to generate Java V1 Protobufs and insert them into the existing JAR for now

2015-10-02 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38967/#review101385 --- src/Makefile.am (line 225)