Re: Review Request 39096: CMake:[1/2] Moved `__WINDOWS__` flag definition to CompilationConfigure.

2015-10-14 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39096/#review102608
---

Ship it!


cleaned up the comment a little.

- Joris Van Remoortere


On Oct. 13, 2015, 6:26 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39096/
> ---
> 
> (Updated Oct. 13, 2015, 6:26 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake:[1/2] Moved `__WINDOWS__` flag definition to CompilationConfigure.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake d1d75098d0ad655a7dcd74628bffd7ba8547b454 
> 
> Diff: https://reviews.apache.org/r/39096/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39096: CMake:[1/2] Moved `__WINDOWS__` flag definition to CompilationConfigure.

2015-10-13 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39096/
---

(Updated Oct. 13, 2015, 6:26 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

CMake:[1/2] Moved `__WINDOWS__` flag definition to CompilationConfigure.


Diffs (updated)
-

  cmake/CompilationConfigure.cmake d1d75098d0ad655a7dcd74628bffd7ba8547b454 

Diff: https://reviews.apache.org/r/39096/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 39096: CMake:[1/2] Moved `__WINDOWS__` flag definition to CompilationConfigure.

2015-10-13 Thread Artem Harutyunyan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39096/#review102541
---



cmake/CompilationConfigure.cmake (line 69)


Is the actuall example missing here?


LGTM.

- Artem Harutyunyan


On Oct. 13, 2015, 11:26 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39096/
> ---
> 
> (Updated Oct. 13, 2015, 11:26 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake:[1/2] Moved `__WINDOWS__` flag definition to CompilationConfigure.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake d1d75098d0ad655a7dcd74628bffd7ba8547b454 
> 
> Diff: https://reviews.apache.org/r/39096/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39096: CMake:[1/2] Moved `__WINDOWS__` flag definition to CompilationConfigure.

2015-10-09 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39096/
---

(Updated Oct. 10, 2015, 4:27 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

CMake:[1/2] Moved `__WINDOWS__` flag definition to CompilationConfigure.


Diffs (updated)
-

  cmake/CompilationConfigure.cmake d1d75098d0ad655a7dcd74628bffd7ba8547b454 

Diff: https://reviews.apache.org/r/39096/diff/


Testing
---


Thanks,

Alex Clemmer