Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

2015-10-13 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39152/#review102498 --- src/slave/containerizer/containerizer.cpp (line 256)

Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

2015-10-13 Thread Greg Mann
> On Oct. 13, 2015, 6:21 p.m., Niklas Nielsen wrote: > > src/slave/containerizer/containerizer.cpp, line 256 > > > > > > Shouldn't we only set this if it is not present? Since it gets set before the `foreach()`

Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

2015-10-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39152/#review102135 --- Patch looks great! Reviews applied: [39152] All tests passed. -

Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

2015-10-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39152/#review102021 --- Patch looks great! Reviews applied: [39152] All tests passed. -

Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

2015-10-09 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39152/#review102108 --- Ship it! LGTM

Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

2015-10-09 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39152/ --- (Updated Oct. 9, 2015, 8:33 p.m.) Review request for mesos and Kapil Arya.

Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

2015-10-09 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39152/#review102116 --- Ship it! Thanks! I'll fix the indent and commit this. Also, you

Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

2015-10-09 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39152/#review102094 --- LGTM! - Cody Maloney On Oct. 9, 2015, 12:57 a.m., Greg Mann

Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

2015-10-09 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39152/#review102098 --- Ship it! Ship It! - Kapil Arya On Oct. 8, 2015, 8:57 p.m.,

Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

2015-10-08 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39152/#review101992 --- src/tests/containerizer/mesos_containerizer_tests.cpp (line 307)

Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

2015-10-08 Thread Greg Mann
> On Oct. 9, 2015, 12:46 a.m., Neil Conway wrote: > > src/tests/containerizer/mesos_containerizer_tests.cpp, line 307 > > > > > > Modifying the environment doesn't seem like a great thing for a test to > > be

Re: Review Request 39152: Pass LIBPROCESS_IP even when executor environment is specified.

2015-10-08 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39152/ --- (Updated Oct. 9, 2015, 12:57 a.m.) Review request for mesos and Kapil Arya.