Re: Review Request 39156: RegistryClient refactor: changed getManifest interface

2015-11-04 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39156/#review105196
---


Bad patch!

Reviews applied: [39013, 38443, 39184, 39155, 39156]

Failed command: ./support/apply-review.sh -n -r 39156

Error:
 2015-11-05 00:58:02 URL:https://reviews.apache.org/r/39156/diff/raw/ 
[4420/4420] -> "39156.patch" [1]
error: src/slave/containerizer/provisioner/docker/registry_client.hpp: does not 
exist in index
error: src/slave/containerizer/provisioner/docker/registry_client.cpp: does not 
exist in index
error: patch failed: src/tests/containerizer/provisioner_docker_tests.cpp:37
error: src/tests/containerizer/provisioner_docker_tests.cpp: patch does not 
apply
Failed to apply patch

- Mesos ReviewBot


On Nov. 4, 2015, 11:48 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39156/
> ---
> 
> (Updated Nov. 4, 2015, 11:48 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> RegistryClient refactor: changed getManifest interface
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/provisioner/docker/registry_client.hpp 
> 1d3377e7462908246dfac90aa0c56314406529c9 
>   src/slave/containerizer/provisioner/docker/registry_client.cpp 
> 471783d88b73b62afacac3d7952ebb5d5f442097 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 9c3c45a81be6398722a37911788e347a4e91cce8 
> 
> Diff: https://reviews.apache.org/r/39156/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>



Re: Review Request 39156: RegistryClient refactor: changed getManifest interface

2015-10-14 Thread Jojy Varghese

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39156/
---

(Updated Oct. 14, 2015, 4:05 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

rebased


Repository: mesos


Description
---

RegistryClient refactor: changed getManifest interface


Diffs (updated)
-

  src/slave/containerizer/provisioner/docker/registry_client.hpp 
1d3377e7462908246dfac90aa0c56314406529c9 
  src/slave/containerizer/provisioner/docker/registry_client.cpp 
471783d88b73b62afacac3d7952ebb5d5f442097 
  src/tests/containerizer/provisioner_docker_tests.cpp 
9c3c45a81be6398722a37911788e347a4e91cce8 

Diff: https://reviews.apache.org/r/39156/diff/


Testing
---

make check.


Thanks,

Jojy Varghese



Re: Review Request 39156: RegistryClient refactor: changed getManifest interface

2015-10-13 Thread Jojy Varghese

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39156/
---

(Updated Oct. 13, 2015, 7:18 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

rebased


Repository: mesos


Description
---

RegistryClient refactor: changed getManifest interface


Diffs (updated)
-

  src/slave/containerizer/provisioner/docker/registry_client.hpp 
fdb68b675582f603ffb3e96f31c1c9405e238567 
  src/slave/containerizer/provisioner/docker/registry_client.cpp 
4931ae8869a697b1e9d8d4cbc0a871e7cd506285 
  src/tests/containerizer/provisioner_docker_tests.cpp 
d895eb9d0723e52cff8b21ef2deeaef1911d019c 

Diff: https://reviews.apache.org/r/39156/diff/


Testing
---

make check.


Thanks,

Jojy Varghese