Re: Review Request 39262: Windows:[1/3] Moved `os::environ` -> `os::raw::environment`.

2015-10-18 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39262/#review103064 --- Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/os/raw/

Re: Review Request 39262: Windows:[1/3] Moved `os::environ` -> `os::raw::environment`.

2015-10-18 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39262/ --- (Updated Oct. 18, 2015, 6:40 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39262: Windows:[1/3] Moved `os::environ` -> `os::raw::environment`.

2015-10-16 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39262/#review102967 --- Ship it! Ship It! - Joseph Wu On Oct. 15, 2015, 1:33 p.m., Alex

Re: Review Request 39262: Windows:[1/3] Moved `os::environ` -> `os::raw::environment`.

2015-10-15 Thread Alex Clemmer
> On Oct. 13, 2015, 8:32 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/raw/environment.hpp, > > lines 34-37 > > > > > > Which header defines the `environ` macro on Windows? And why i

Re: Review Request 39262: Windows:[1/3] Moved `os::environ` -> `os::raw::environment`.

2015-10-15 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39262/ --- (Updated Oct. 15, 2015, 8:33 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 39262: Windows:[1/3] Moved `os::environ` -> `os::raw::environment`.

2015-10-15 Thread Alex Clemmer
> On Oct. 13, 2015, 8:32 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/raw/environment.hpp, > > lines 34-37 > > > > > > Which header defines the `environ` macro on Windows? And why i

Re: Review Request 39262: Windows:[1/3] Moved `os::environ` -> `os::raw::environment`.

2015-10-13 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39262/#review102526 --- 3rdparty/libprocess/3rdparty/stout/include/stout/os/raw/environmen

Re: Review Request 39262: Windows:[1/3] Moved `os::environ` -> `os::raw::environment`.

2015-10-13 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39262/ --- (Updated Oct. 13, 2015, 6:36 p.m.) Review request for mesos, Artem Harutyunyan,