Re: Review Request 39276: Fixed a bug with HTTP pipelining in libprocess.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39276/#review106224
---

Ship it!


Thanks for pulling this into its own patch, looks good!


3rdparty/libprocess/src/process.cpp (lines 2334 - 2336)


I was a bit confused by the safety comment, is it not covered by the 
ownership comment?


- Ben Mahler


On Nov. 12, 2015, 11:20 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39276/
> ---
> 
> (Updated Nov. 12, 2015, 11:20 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Bernd Mathiske, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3705
> https://issues.apache.org/jira/browse/MESOS-3705
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Response futures were being added to the pipeline not when the requests 
> arrived but when the event was visited. This can result in out of order 
> responses.
> 
> This patch fixes that problem enforcing that every response is sent in the 
> order the corresponding request arrived.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/event.hpp 
> 16ddbd77afa6efdf6bad201aa497ee102aa863ae 
>   3rdparty/libprocess/src/process.cpp 
> a94712b9ac3b60fb047b3a5a4d84a56fa4d02313 
> 
> Diff: https://reviews.apache.org/r/39276/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 39276: Fixed a bug with HTTP pipelining in libprocess.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39276/
---

(Updated Nov. 12, 2015, 12:20 p.m.)


Review request for mesos, Anand Mazumdar, Bernd Mathiske, and Till Toenshoff.


Summary (updated)
-

Fixed a bug with HTTP pipelining in libprocess.


Bugs: MESOS-3705
https://issues.apache.org/jira/browse/MESOS-3705


Repository: mesos


Description (updated)
---

Response futures were being added to the pipeline not when the requests arrived 
but when the event was visited. This can result in out of order responses.

This patch fixes that problem enforcing that every response is sent in the 
order the corresponding request arrived.


Diffs (updated)
-

  3rdparty/libprocess/include/process/event.hpp 
16ddbd77afa6efdf6bad201aa497ee102aa863ae 
  3rdparty/libprocess/src/process.cpp a94712b9ac3b60fb047b3a5a4d84a56fa4d02313 

Diff: https://reviews.apache.org/r/39276/diff/


Testing
---

make check


Thanks,

Alexander Rojas