Re: Review Request 39358: Network monitoring metrics table has common style

2015-11-02 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39358/#review104769
---

Ship it!


Ship It!

- Joris Van Remoortere


On Oct. 29, 2015, 10:48 a.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39358/
> ---
> 
> (Updated Oct. 29, 2015, 10:48 a.m.)
> 
> 
> Review request for mesos, Dave Lester, Jie Yu, and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Network monitoring metrics table has common style
> 
> 
> Diffs
> -
> 
>   docs/network-monitoring.md b266ae5 
> 
> Diff: https://reviews.apache.org/r/39358/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 39358: Network monitoring metrics table has common style

2015-10-29 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39358/#review104418
---


Patch looks great!

Reviews applied: [39358]

All tests passed.

- Mesos ReviewBot


On Oct. 29, 2015, 10:48 a.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39358/
> ---
> 
> (Updated Oct. 29, 2015, 10:48 a.m.)
> 
> 
> Review request for mesos, Dave Lester, Jie Yu, and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Network monitoring metrics table has common style
> 
> 
> Diffs
> -
> 
>   docs/network-monitoring.md b266ae5 
> 
> Diff: https://reviews.apache.org/r/39358/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 39358: Network monitoring metrics table has common style

2015-10-29 Thread Tomasz Janiszewski 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39358/
---

(Updated Oct. 29, 2015, 8:44 a.m.)


Review request for mesos, Dave Lester, Jie Yu, and Joris Van Remoortere.


Repository: mesos


Description
---

Network monitoring metrics table has common style


Diffs (updated)
-

  docs/network-monitoring.md b266ae59cd698ed11dc49ee1987efb868e2ef746 

Diff: https://reviews.apache.org/r/39358/diff/


Testing
---


Thanks,

Tomasz Janiszewski

Re: Review Request 39358: Network monitoring metrics table has common style

2015-10-29 Thread Tomasz Janiszewski 


> On Oct. 28, 2015, 10:30 p.m., Joris Van Remoortere wrote:
> > docs/network-monitoring.md, line 291
> > 
> >
> > `[3]` applies to more than 1 field in the table right?
> > I think this is why the message was more generic to begin with?
> > What do you think / want to do about this?

Good catch. My bad, I reverted that change


- Tomasz


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39358/#review104360
---


On Oct. 29, 2015, 8:44 a.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39358/
> ---
> 
> (Updated Oct. 29, 2015, 8:44 a.m.)
> 
> 
> Review request for mesos, Dave Lester, Jie Yu, and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Network monitoring metrics table has common style
> 
> 
> Diffs
> -
> 
>   docs/network-monitoring.md b266ae59cd698ed11dc49ee1987efb868e2ef746 
> 
> Diff: https://reviews.apache.org/r/39358/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 39358: Network monitoring metrics table has common style

2015-10-29 Thread Tomasz Janiszewski 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39358/
---

(Updated Oct. 29, 2015, 10:48 a.m.)


Review request for mesos, Dave Lester, Jie Yu, and Joris Van Remoortere.


Repository: mesos


Description
---

Network monitoring metrics table has common style


Diffs (updated)
-

  docs/network-monitoring.md b266ae5 

Diff: https://reviews.apache.org/r/39358/diff/


Testing
---


Thanks,

Tomasz Janiszewski

Re: Review Request 39358: Network monitoring metrics table has common style

2015-10-29 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39358/#review104412
---


Bad patch!

Reviews applied: [39358]

Failed command: ./support/apply-review.sh -n -r 39358

Error:
 2015-10-29 10:33:40 URL:https://reviews.apache.org/r/39358/diff/raw/ 
[1305/1305] -> "39358.patch" [1]
fatal: corrupt patch at line 35
Failed to apply patch

- Mesos ReviewBot


On Oct. 29, 2015, 8:44 a.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39358/
> ---
> 
> (Updated Oct. 29, 2015, 8:44 a.m.)
> 
> 
> Review request for mesos, Dave Lester, Jie Yu, and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Network monitoring metrics table has common style
> 
> 
> Diffs
> -
> 
>   docs/network-monitoring.md b266ae59cd698ed11dc49ee1987efb868e2ef746 
> 
> Diff: https://reviews.apache.org/r/39358/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 39358: Network monitoring metrics table has common style

2015-10-28 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39358/#review104360
---



docs/network-monitoring.md (line 291)


`[3]` applies to more than 1 field in the table right?
I think this is why the message was more generic to begin with?
What do you think / want to do about this?


- Joris Van Remoortere


On Oct. 21, 2015, 3:33 p.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39358/
> ---
> 
> (Updated Oct. 21, 2015, 3:33 p.m.)
> 
> 
> Review request for mesos, Dave Lester, Jie Yu, and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Network monitoring metrics table has common style
> 
> 
> Diffs
> -
> 
>   docs/network-monitoring.md b266ae59cd698ed11dc49ee1987efb868e2ef746 
> 
> Diff: https://reviews.apache.org/r/39358/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 39358: Network monitoring metrics table has common style

2015-10-15 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39358/#review102830
---


Patch looks great!

Reviews applied: [39358]

All tests passed.

- Mesos ReviewBot


On Oct. 15, 2015, 8:18 p.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39358/
> ---
> 
> (Updated Oct. 15, 2015, 8:18 p.m.)
> 
> 
> Review request for mesos, Dave Lester and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Network monitoring metrics table has common style
> 
> 
> Diffs
> -
> 
>   docs/network-monitoring.md b266ae59cd698ed11dc49ee1987efb868e2ef746 
> 
> Diff: https://reviews.apache.org/r/39358/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>