Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Dec. 10, 2015, 1:42 p.m.) Review request for mesos, Adam B, Joris Van

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Dec. 10, 2015, 1:35 p.m.) Review request for mesos, Adam B, Joris Van

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Nov. 14, 2015, 9:02 a.m.) Review request for mesos, Adam B, Joris Van

Re: Review Request 39410: Added support for github to apply-reviews.py.

> On Nov. 10, 2015, 12:18 p.m., Vinod Kone wrote: > > support/apply-reviews.py, line 192 > > > > > > s/-e/--amend/ ? Turns out `--amend` is very different from `-e`. `--amend` causes all commits in the branch t

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Nov. 12, 2015, 10:03 a.m.) Review request for mesos, Adam B, Joris Van

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Nov. 12, 2015, 2:51 a.m.) Review request for mesos, Adam B, Joris Van

Re: Review Request 39410: Added support for github to apply-reviews.py.

> On Nov. 10, 2015, 4:11 a.m., Kapil Arya wrote: > > support/apply-reviews.py, lines 196-197 > > > > > > Can we enhance it as following: > > ``` > > amend=options['no_amend'] ? '' : '-e' > > cmd = 'git c

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Nov. 11, 2015, 2:10 a.m.) Review request for mesos, Adam B, Joris Van

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/#review105939 --- Ship it! support/apply-reviews.py (line 188)

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Nov. 9, 2015, 11:48 p.m.) Review request for mesos, Adam B, Joris Van

Re: Review Request 39410: Added support for github to apply-reviews.py.

> On Nov. 9, 2015, 8:11 p.m., Kapil Arya wrote: > > support/apply-reviews.py, lines 196-197 > > > > > > Can we enhance it as following: > > ``` > > amend=options['no_amend'] ? '' : '-e' > > cmd = 'git co

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/#review105786 --- support/apply-reviews.py (lines 187 - 188)

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/#review105728 --- Ship it! support/apply-reviews.py (line 42)

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Nov. 9, 2015, 7:32 a.m.) Review request for mesos, Adam B, Joris Van R

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Nov. 9, 2015, 6:19 a.m.) Review request for mesos, Adam B, Joris Van R

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Nov. 9, 2015, 2:57 a.m.) Review request for mesos, Adam B, Joris Van R

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Nov. 9, 2015, 12:30 a.m.) Review request for mesos, Adam B, Joris Van

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Nov. 4, 2015, 3 p.m.) Review request for mesos, Adam B, Joris Van Remo

Re: Review Request 39410: Added support for github to apply-reviews.py.

> On Nov. 2, 2015, 4:55 p.m., Vinod Kone wrote: > > support/apply-reviews.py, line 132 > > > > > > this is weird too. a 'remove patch' function which takes optional patch > > as an argument. Added a comment to cl

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/#review104831 --- support/apply-reviews.py (line 47)

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Oct. 30, 2015, 1:55 a.m.) Review request for mesos, Adam B, Joris Van

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Oct. 28, 2015, 3:08 p.m.) Review request for mesos, Adam B, Joris Van

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/#review104111 --- support/apply-reviews.py (line 38)

Re: Review Request 39410: Added support for github to apply-reviews.py.

> On Oct. 23, 2015, 12:18 a.m., Marco Massenzio wrote: > > support/apply-reviews.py, lines 287-290 > > > > > > does this work? (I really am curious, I didn't know about the 'mutually > > exclusive' option!) > >

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Oct. 23, 2015, 4:13 p.m.) Review request for mesos, Adam B, Joris Van

Re: Review Request 39410: Added support for github to apply-reviews.py.

> On Oct. 20, 2015, 5:06 a.m., Marco Massenzio wrote: > > support/apply-reviews.py, line 160 > > > > > > you don't really need to escape the quotes, just take advantage of > > Python being able to use single and dou

Re: Review Request 39410: Added support for github to apply-reviews.py.

> On Oct. 19, 2015, 10:06 p.m., Marco Massenzio wrote: > > support/apply-reviews.py, line 160 > > > > > > you don't really need to escape the quotes, just take advantage of > > Python being able to use single and do

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/#review103731 --- Ship it! This looks great - a really few minor nits, but then it's

Re: Review Request 39410: Added support for github to apply-reviews.py.

> On Oct. 19, 2015, 10:06 p.m., Marco Massenzio wrote: > > support/apply-reviews.py, lines 277-282 > > > > > > this code look familiar and I remember already commenting about > > `applied` :) > > Artem Harutyunyan

Re: Review Request 39410: Added support for github to apply-reviews.py.

> On Oct. 20, 2015, 5:06 a.m., Marco Massenzio wrote: > > support/apply-reviews.py, line 160 > > > > > > you don't really need to escape the quotes, just take advantage of > > Python being able to use single and dou

Re: Review Request 39410: Added support for github to apply-reviews.py.

> On Oct. 20, 2015, 5:06 a.m., Marco Massenzio wrote: > > support/apply-reviews.py, line 106 > > > > > > it would be really nice if we could make our code work under both 2.7 > > and 3.x Python ;) > > Artem Harutyu

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Oct. 22, 2015, 11:18 p.m.) Review request for mesos, Adam B, Joris Van

Re: Review Request 39410: Added support for github to apply-reviews.py.

> On Oct. 19, 2015, 10:06 p.m., Marco Massenzio wrote: > > support/apply-reviews.py, line 47 > > > > > > could you please add an @param and explain what `options` is and what > > does it look like? > > (also an @

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Oct. 20, 2015, 11:04 p.m.) Review request for mesos, Adam B, Joris Van

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Oct. 20, 2015, 12:45 a.m.) Review request for mesos, Adam B, Joris Van

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/#review103208 --- support/apply-reviews.py (line 23)

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Oct. 18, 2015, 3:32 p.m.) Review request for mesos, Adam B, Joris Van

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/ --- (Updated Oct. 17, 2015, 7:40 p.m.) Review request for mesos, Adam B, Joris Van

Re: Review Request 39410: Added support for github to apply-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/#review103006 --- Patch looks great! Reviews applied: [38705, 38883, 39410] All tes