Re: Review Request 39453: Added HTTP docs to libprocess README.md.

2015-11-08 Thread Benjamin Hindman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39453/#review105641
---

Ship it!


Made a few minor edits to make this code compilable (e.g., `initialize` was 
missing a closing right parenthesis) as well as making some things better match 
our style. Thanks Greg! Committing this now.

- Benjamin Hindman


On Nov. 4, 2015, 5:28 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39453/
> ---
> 
> (Updated Nov. 4, 2015, 5:28 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP docs to libprocess README.md.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d 
> 
> Diff: https://reviews.apache.org/r/39453/diff/
> 
> 
> Testing
> ---
> 
> https://gist.github.com/greggomann/b5b35a164a006bec9357
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 39453: Added HTTP docs to libprocess README.md.

2015-11-04 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39453/
---

(Updated Nov. 4, 2015, 5:28 p.m.)


Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Neil Conway.


Repository: mesos


Description
---

Added HTTP docs to libprocess README.md.


Diffs (updated)
-

  3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d 

Diff: https://reviews.apache.org/r/39453/diff/


Testing
---

https://gist.github.com/greggomann/b5b35a164a006bec9357


Thanks,

Greg Mann



Re: Review Request 39453: Added HTTP docs to libprocess README.md.

2015-10-21 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39453/#review103464
---


Patch looks great!

Reviews applied: [39453]

All tests passed.

- Mesos ReviewBot


On Oct. 21, 2015, 5:53 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39453/
> ---
> 
> (Updated Oct. 21, 2015, 5:53 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP docs to libprocess README.md.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d 
> 
> Diff: https://reviews.apache.org/r/39453/diff/
> 
> 
> Testing
> ---
> 
> https://gist.github.com/greggomann/b5b35a164a006bec9357
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 39453: Added HTTP docs to libprocess README.md.

2015-10-21 Thread Greg Mann


> On Oct. 21, 2015, 1:51 a.m., Guangya Liu wrote:
> > 3rdparty/libprocess/README.md, line 452
> > 
> >
> > s/noting/nothing

Here, I'm saying something to the effect of "It's also worthy of note that if 
multiple requests...", so the word "noting" is appropriate.


> On Oct. 21, 2015, 1:51 a.m., Guangya Liu wrote:
> > 3rdparty/libprocess/README.md, line 403
> > 
> >
> > Can you please add sth for how to get the listening port?

Good call, thanks Guangya :-)


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39453/#review103337
---


On Oct. 21, 2015, 5:53 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39453/
> ---
> 
> (Updated Oct. 21, 2015, 5:53 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP docs to libprocess README.md.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d 
> 
> Diff: https://reviews.apache.org/r/39453/diff/
> 
> 
> Testing
> ---
> 
> https://gist.github.com/greggomann/b5b35a164a006bec9357
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 39453: Added HTTP docs to libprocess README.md.

2015-10-21 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39453/
---

(Updated Oct. 21, 2015, 5:53 p.m.)


Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Neil Conway.


Changes
---

Addressed comments.


Repository: mesos


Description
---

Added HTTP docs to libprocess README.md.


Diffs (updated)
-

  3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d 

Diff: https://reviews.apache.org/r/39453/diff/


Testing
---

https://gist.github.com/greggomann/b5b35a164a006bec9357


Thanks,

Greg Mann



Re: Review Request 39453: Added HTTP docs to libprocess README.md.

2015-10-21 Thread Guangya Liu


> On 十月 21, 2015, 1:51 a.m., Guangya Liu wrote:
> > 3rdparty/libprocess/README.md, line 452
> > 
> >
> > s/noting/nothing
> 
> Greg Mann wrote:
> Here, I'm saying something to the effect of "It's also worthy of note 
> that if multiple requests...", so the word "noting" is appropriate.

My bad, thanks Greg! ;-)


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39453/#review103337
---


On 十月 21, 2015, 5:53 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39453/
> ---
> 
> (Updated 十月 21, 2015, 5:53 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP docs to libprocess README.md.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d 
> 
> Diff: https://reviews.apache.org/r/39453/diff/
> 
> 
> Testing
> ---
> 
> https://gist.github.com/greggomann/b5b35a164a006bec9357
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 39453: Added HTTP docs to libprocess README.md.

2015-10-20 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39453/#review103337
---



3rdparty/libprocess/README.md (line 371)


virtual?



3rdparty/libprocess/README.md (line 396)


Can you please add sth for how to get the listening port?



3rdparty/libprocess/README.md (line 445)


s/noting/nothing


- Guangya Liu


On 十月 19, 2015, 9:35 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39453/
> ---
> 
> (Updated 十月 19, 2015, 9:35 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP docs to libprocess README.md.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d 
> 
> Diff: https://reviews.apache.org/r/39453/diff/
> 
> 
> Testing
> ---
> 
> https://gist.github.com/greggomann/b5b35a164a006bec9357
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 39453: Added HTTP docs to libprocess README.md.

2015-10-19 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39453/
---

(Updated Oct. 19, 2015, 9:35 p.m.)


Review request for mesos, Anand Mazumdar and Benjamin Hindman.


Repository: mesos


Description
---

Added HTTP docs to libprocess README.md.


Diffs (updated)
-

  3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d 

Diff: https://reviews.apache.org/r/39453/diff/


Testing (updated)
---

https://gist.github.com/greggomann/b5b35a164a006bec9357


Thanks,

Greg Mann



Re: Review Request 39453: Added HTTP docs to libprocess README.md.

2015-10-19 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39453/
---

(Updated Oct. 19, 2015, 9:10 p.m.)


Review request for mesos, Anand Mazumdar and Benjamin Hindman.


Repository: mesos


Description
---

Added HTTP docs to libprocess README.md.


Diffs (updated)
-

  3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d 

Diff: https://reviews.apache.org/r/39453/diff/


Testing
---


Thanks,

Greg Mann



Re: Review Request 39453: Added HTTP docs to libprocess README.md.

2015-10-19 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39453/
---

(Updated Oct. 19, 2015, 8:39 p.m.)


Review request for mesos and Benjamin Hindman.


Repository: mesos


Description
---

Added HTTP docs to libprocess README.md.


Diffs (updated)
-

  3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d 

Diff: https://reviews.apache.org/r/39453/diff/


Testing
---


Thanks,

Greg Mann



Re: Review Request 39453: Added HTTP docs to libprocess README.md.

2015-10-19 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39453/
---

(Updated Oct. 19, 2015, 8:58 p.m.)


Review request for mesos and Benjamin Hindman.


Repository: mesos


Description
---

Added HTTP docs to libprocess README.md.


Diffs (updated)
-

  3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d 

Diff: https://reviews.apache.org/r/39453/diff/


Testing
---


Thanks,

Greg Mann



Re: Review Request 39453: Added HTTP docs to libprocess README.md.

2015-10-19 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39453/
---

(Updated Oct. 19, 2015, 9:14 p.m.)


Review request for mesos, Anand Mazumdar and Benjamin Hindman.


Repository: mesos


Description
---

Added HTTP docs to libprocess README.md.


Diffs (updated)
-

  3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d 

Diff: https://reviews.apache.org/r/39453/diff/


Testing
---


Thanks,

Greg Mann



Re: Review Request 39453: Added HTTP docs to libprocess README.md.

2015-10-19 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39453/
---

(Updated Oct. 19, 2015, 8:48 p.m.)


Review request for mesos and Benjamin Hindman.


Repository: mesos


Description
---

Added HTTP docs to libprocess README.md.


Diffs (updated)
-

  3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d 

Diff: https://reviews.apache.org/r/39453/diff/


Testing
---


Thanks,

Greg Mann



Re: Review Request 39453: Added HTTP docs to libprocess README.md.

2015-10-19 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39453/
---

(Updated Oct. 19, 2015, 9:07 p.m.)


Review request for mesos, Anand Mazumdar and Benjamin Hindman.


Repository: mesos


Description
---

Added HTTP docs to libprocess README.md.


Diffs (updated)
-

  3rdparty/libprocess/README.md 769b79f9a9f816e618dfde62b653e3194386908d 

Diff: https://reviews.apache.org/r/39453/diff/


Testing
---


Thanks,

Greg Mann