Re: Review Request 39474: Added test "ROOT_CommandTaskRootfsWithVolumes".

[Guangya Liu]

> On 五月 5, 2016, 7:18 p.m., Jie Yu wrote:
> > src/tests/containerizer/docker_volume_isolator_tests.cpp, line 839
> > 
> >
> > I'll use INTERNET_CURL filter and use alpine directly (rather than 
> > creating our own rootfs using LinuxRootfs) for now since the linuxrootfs is 
> > so big depending on linux distribution.

So you mean that the test case need to pull the `alpine` image from docker hub 
for the test, right?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39474/#review131899
---


On 五月 5, 2016, 6:31 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39474/
> ---
> 
> (Updated 五月 5, 2016, 6:31 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5266
> https://issues.apache.org/jira/browse/MESOS-5266
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test "ROOT_CommandTaskRootfsWithVolumes".
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_volume_isolator_tests.cpp 
> 7fcb289b8701424d17567710fe5f8627d6fe25b6 
> 
> Diff: https://reviews.apache.org/r/39474/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> GLOG_v=1 ./bin/mesos-tests.sh  
> --gtest_filter="DockerVolumeIsolatorTest.ROOT_CommandTaskRootfsWithVolumes" 
> --verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 39474: Added test "ROOT_CommandTaskRootfsWithVolumes".

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39474/#review131969
---



Patch looks great!

Reviews applied: [46680, 46681, 46682, 46140, 42028, 38451, 0, 39474]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 5, 2016, 6:31 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39474/
> ---
> 
> (Updated May 5, 2016, 6:31 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5266
> https://issues.apache.org/jira/browse/MESOS-5266
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test "ROOT_CommandTaskRootfsWithVolumes".
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_volume_isolator_tests.cpp 
> 7fcb289b8701424d17567710fe5f8627d6fe25b6 
> 
> Diff: https://reviews.apache.org/r/39474/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> GLOG_v=1 ./bin/mesos-tests.sh  
> --gtest_filter="DockerVolumeIsolatorTest.ROOT_CommandTaskRootfsWithVolumes" 
> --verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 39474: Added test "ROOT_CommandTaskRootfsWithVolumes".

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39474/#review131899
---




src/tests/containerizer/docker_volume_isolator_tests.cpp (line 834)


I'll use INTERNET_CURL filter and use alpine directly (rather than creating 
our own rootfs using LinuxRootfs) for now since the linuxrootfs is so big 
depending on linux distribution.


- Jie Yu


On May 5, 2016, 6:31 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39474/
> ---
> 
> (Updated May 5, 2016, 6:31 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5266
> https://issues.apache.org/jira/browse/MESOS-5266
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test "ROOT_CommandTaskRootfsWithVolumes".
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_volume_isolator_tests.cpp 
> 7fcb289b8701424d17567710fe5f8627d6fe25b6 
> 
> Diff: https://reviews.apache.org/r/39474/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> GLOG_v=1 ./bin/mesos-tests.sh  
> --gtest_filter="DockerVolumeIsolatorTest.ROOT_CommandTaskRootfsWithVolumes" 
> --verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 39474: Added test "ROOT_CommandTaskRootfsWithVolumes".

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39474/
---

(Updated 五月 5, 2016, 6:31 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-5266
https://issues.apache.org/jira/browse/MESOS-5266


Repository: mesos


Description
---

Added test "ROOT_CommandTaskRootfsWithVolumes".


Diffs (updated)
-

  src/tests/containerizer/docker_volume_isolator_tests.cpp 
7fcb289b8701424d17567710fe5f8627d6fe25b6 

Diff: https://reviews.apache.org/r/39474/diff/


Testing
---

make
make check
GLOG_v=1 ./bin/mesos-tests.sh  
--gtest_filter="DockerVolumeIsolatorTest.ROOT_CommandTaskRootfsWithVolumes" 
--verbose


Thanks,

Guangya Liu

Re: Review Request 39474: Added test "ROOT_CommandTaskRootfsWithVolumes".

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39474/#review131697
---



Patch looks great!

Reviews applied: [46680, 46681, 46682, 46140, 42028, 38451, 39474]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 4, 2016, 2:33 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39474/
> ---
> 
> (Updated May 4, 2016, 2:33 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5266
> https://issues.apache.org/jira/browse/MESOS-5266
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test "ROOT_CommandTaskRootfsWithVolumes".
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_volume_isolator_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39474/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> GLOG_v=1 ./bin/mesos-tests.sh  
> --gtest_filter="DockerVolumeIsolatorTest.ROOT_CommandTaskRootfsWithVolumes" 
> --verbose
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 39474: Added test "ROOT_CommandTaskRootfsWithVolumes".

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39474/
---

(Updated 五月 4, 2016, 2:33 p.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Summary (updated)
-

Added test "ROOT_CommandTaskRootfsWithVolumes".


Bugs: MESOS-5266
https://issues.apache.org/jira/browse/MESOS-5266


Repository: mesos


Description (updated)
---

Added test "ROOT_CommandTaskRootfsWithVolumes".


Diffs (updated)
-

  src/tests/containerizer/docker_volume_isolator_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39474/diff/


Testing (updated)
---

make
make check
GLOG_v=1 ./bin/mesos-tests.sh  
--gtest_filter="DockerVolumeIsolatorTest.ROOT_CommandTaskRootfsWithVolumes" 
--verbose


Thanks,

Guangya Liu