Re: Review Request 39502: [DO NOT COMMIT] Sync v1/mesos.proto with docker, QoS, and AppC changes.

2015-11-02 Thread Kapil Arya


> On Oct. 21, 2015, 3:31 p.m., Kapil Arya wrote:
> > Ship It!
> 
> Joseph Wu wrote:
> Just to confirm, https://reviews.apache.org/r/38367/diff/4#0 was omitted 
> from V1 unintentionally?

Yes, that was an oversight on my end. Thanks for fixing this, Joseph!!


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39502/#review103456
---


On Oct. 26, 2015, 5:27 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39502/
> ---
> 
> (Updated Oct. 26, 2015, 5:27 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, Joris Van Remoortere, 
> Kapil Arya, Niklas Nielsen, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added in reviews:
> 
> * https://reviews.apache.org/r/37196/
> * https://reviews.apache.org/r/37308/ <- Confirmed as unintentional
> * https://reviews.apache.org/r/38253/
> * https://reviews.apache.org/r/38367/
> ** NetworkInfo moved up the review chain.
> * 
> https://github.com/apache/mesos/commit/140311f263a6ae54d3d211c9c91e4bf55d2eb0f1
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/mesos.proto 8131778fe5c5f3a47ae9300a811e3d857a22da6a 
> 
> Diff: https://reviews.apache.org/r/39502/diff/
> 
> 
> Testing
> ---
> 
> `make`
> 
> For now, this review is meant for checking which of these differences are 
> intentional.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Re: Review Request 39502: [DO NOT COMMIT] Sync v1/mesos.proto with docker, QoS, and AppC changes.

2015-10-26 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39502/
---

(Updated Oct. 26, 2015, 2:27 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, Joris Van Remoortere, 
Kapil Arya, Niklas Nielsen, and Timothy Chen.


Changes
---

Changing title, since not all changes have been confirmed yet.


Summary (updated)
-

[DO NOT COMMIT] Sync v1/mesos.proto with docker, QoS, and AppC changes.


Repository: mesos


Description
---

Added in reviews:

* https://reviews.apache.org/r/37196/
* https://reviews.apache.org/r/37308/ <- Confirmed as unintentional
* https://reviews.apache.org/r/38253/
* https://reviews.apache.org/r/38367/
** NetworkInfo moved up the review chain.
* 
https://github.com/apache/mesos/commit/140311f263a6ae54d3d211c9c91e4bf55d2eb0f1


Diffs
-

  include/mesos/v1/mesos.proto 8131778fe5c5f3a47ae9300a811e3d857a22da6a 

Diff: https://reviews.apache.org/r/39502/diff/


Testing
---

`make`

For now, this review is meant for checking which of these differences are 
intentional.


Thanks,

Joseph Wu