Re: Review Request 39534: SSLTest refactor: Change MesosTest to inherit from the SSL helper class.

2015-11-03 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39534/#review105020
---



src/tests/mesos.hpp (line 103)


We have two 'TemporaryDirectoryTest' (one in stout, one in mesos). There's 
some subtle differences between the two (e.g., the temp directory naming, 
umount unneeded mounts)

MesosTest inherits from TemporaryDirectoryTest in Mesos previously. This 
change breaks the test (if you run under root).


- Jie Yu


On Oct. 26, 2015, 10:37 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39534/
> ---
> 
> (Updated Oct. 26, 2015, 10:37 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3762
> https://issues.apache.org/jira/browse/MESOS-3762
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp 3e58b454c75a2ab9f8b4a29785fa823afefd0c8a 
> 
> Diff: https://reviews.apache.org/r/39534/diff/
> 
> 
> Testing
> ---
> 
> ```
> ../configure
> make check
> ```
> 
> ```
> ../configure --enable-ssl --enable-libevent
> make check
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 39534: SSLTest refactor: Change MesosTest to inherit from the SSL helper class.

2015-10-26 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39534/#review104087
---



src/tests/mesos.hpp (line 100)


As per offline discussion, let's comment explaining why it is ok to do this 
regardless of ssl configuration.


- Joris Van Remoortere


On Oct. 22, 2015, 12:04 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39534/
> ---
> 
> (Updated Oct. 22, 2015, 12:04 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3762
> https://issues.apache.org/jira/browse/MESOS-3762
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp 3e58b454c75a2ab9f8b4a29785fa823afefd0c8a 
> 
> Diff: https://reviews.apache.org/r/39534/diff/
> 
> 
> Testing
> ---
> 
> ```
> ../configure
> make check
> ```
> 
> ```
> ../configure --enable-ssl --enable-libevent
> make check
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 39534: SSLTest refactor: Change MesosTest to inherit from the SSL helper class.

2015-10-26 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39534/
---

(Updated Oct. 26, 2015, 3:37 p.m.)


Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Changes
---

Add comment above change.


Bugs: MESOS-3762
https://issues.apache.org/jira/browse/MESOS-3762


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/tests/mesos.hpp 3e58b454c75a2ab9f8b4a29785fa823afefd0c8a 

Diff: https://reviews.apache.org/r/39534/diff/


Testing
---

```
../configure
make check
```

```
../configure --enable-ssl --enable-libevent
make check
```


Thanks,

Joseph Wu

Re: Review Request 39534: SSLTest refactor: Change MesosTest to inherit from the SSL helper class.

2015-10-26 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39534/#review104110
---


Patch looks great!

Reviews applied: [39495, 39498, 39499, 39501, 39533, 39534]

All tests passed.

- Mesos ReviewBot


On Oct. 26, 2015, 10:37 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39534/
> ---
> 
> (Updated Oct. 26, 2015, 10:37 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3762
> https://issues.apache.org/jira/browse/MESOS-3762
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp 3e58b454c75a2ab9f8b4a29785fa823afefd0c8a 
> 
> Diff: https://reviews.apache.org/r/39534/diff/
> 
> 
> Testing
> ---
> 
> ```
> ../configure
> make check
> ```
> 
> ```
> ../configure --enable-ssl --enable-libevent
> make check
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 39534: SSLTest refactor: Change MesosTest to inherit from the SSL helper class.

2015-10-21 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39534/#review103503
---


Patch looks great!

Reviews applied: [39495, 39498, 39499, 39501, 39533, 39534]

All tests passed.

- Mesos ReviewBot


On Oct. 22, 2015, 12:04 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39534/
> ---
> 
> (Updated Oct. 22, 2015, 12:04 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3762
> https://issues.apache.org/jira/browse/MESOS-3762
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp 3e58b454c75a2ab9f8b4a29785fa823afefd0c8a 
> 
> Diff: https://reviews.apache.org/r/39534/diff/
> 
> 
> Testing
> ---
> 
> ```
> ../configure
> make check
> ```
> 
> ```
> ../configure --enable-ssl --enable-libevent
> make check
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>