Re: Review Request 39539: Windows: Moved `os::mktemp` to its own file, `stout/os/mktemp.hpp`.

2015-10-28 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39539/#review104052
---

Ship it!



3rdparty/libprocess/3rdparty/stout/include/Makefile.am (lines 78 - 81)


order?



3rdparty/libprocess/3rdparty/stout/include/stout/os/mktemp.hpp (line 16)


``
``



3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp (line 232)


We can add a comment here about the flag we're using to try and emulate the 
POSIX behavior.


- Joris Van Remoortere


On Oct. 27, 2015, 6:32 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39539/
> ---
> 
> (Updated Oct. 27, 2015, 6:32 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Moved `os::mktemp` to its own file, `stout/os/mktemp.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> ba2836a72ceee948cb43364e80ada9f132f33d04 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 7f70c9ea7d57634b5bfd40523ba37561ec92a09a 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/mktemp.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> 7a8819541506f57f70a9b577dc97a76fc26ebaa8 
> 
> Diff: https://reviews.apache.org/r/39539/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39539: Windows: Moved `os::mktemp` to its own file, `stout/os/mktemp.hpp`.

2015-10-27 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39539/
---

(Updated Oct. 27, 2015, 6:32 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Bugs: MESOS-3441
https://issues.apache.org/jira/browse/MESOS-3441


Repository: mesos


Description
---

Windows: Moved `os::mktemp` to its own file, `stout/os/mktemp.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
ba2836a72ceee948cb43364e80ada9f132f33d04 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
7f70c9ea7d57634b5bfd40523ba37561ec92a09a 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/mktemp.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
7a8819541506f57f70a9b577dc97a76fc26ebaa8 

Diff: https://reviews.apache.org/r/39539/diff/


Testing
---

`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.


Thanks,

Alex Clemmer

Re: Review Request 39539: Windows: Moved `os::mktemp` to its own file, `stout/os/mktemp.hpp`.

2015-10-26 Thread Joris Van Remoortere 


> On Oct. 23, 2015, 4:49 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp, lines 270-274
> > 
> >
> > Do you need this one?

There are some uses of `os::mktemp` in the code-base.


> On Oct. 23, 2015, 4:49 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp, lines 280-284
> > 
> >
> > Why is this function body different than all the other alias-like 
> > functions?
> > 
> > i.e. You could comment that stout/mktemp needs an open file, or similar.

Agree with Joseph.
This is not obvious, had to look at the documentation for linux's mkstemp().


- Joris


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39539/#review103793
---


On Oct. 22, 2015, 3:35 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39539/
> ---
> 
> (Updated Oct. 22, 2015, 3:35 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Moved `os::mktemp` to its own file, `stout/os/mktemp.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> ba2836a72ceee948cb43364e80ada9f132f33d04 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 7f70c9ea7d57634b5bfd40523ba37561ec92a09a 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/mktemp.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> 7a8819541506f57f70a9b577dc97a76fc26ebaa8 
> 
> Diff: https://reviews.apache.org/r/39539/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39539: Windows: Moved `os::mktemp` to its own file, `stout/os/mktemp.hpp`.

2015-10-23 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39539/#review103793
---


Confirmed that mktemp logic was unchanged.


3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp (lines 213 - 217)


Do you need this one?



3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp (lines 223 - 227)


Why is this function body different than all the other alias-like functions?

i.e. You could comment that stout/mktemp needs an open file, or similar.


- Joseph Wu


On Oct. 21, 2015, 8:35 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39539/
> ---
> 
> (Updated Oct. 21, 2015, 8:35 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Moved `os::mktemp` to its own file, `stout/os/mktemp.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> ba2836a72ceee948cb43364e80ada9f132f33d04 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 7f70c9ea7d57634b5bfd40523ba37561ec92a09a 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/mktemp.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> 7a8819541506f57f70a9b577dc97a76fc26ebaa8 
> 
> Diff: https://reviews.apache.org/r/39539/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39539: Windows: Moved `os::mktemp` to its own file, `stout/os/mktemp.hpp`.

2015-10-21 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39539/#review103521
---



3rdparty/libprocess/3rdparty/stout/include/stout/os/mktemp.hpp (line 32)


Oh yeah. Forgot to mention: this _totally works_ in Windows! If you do this 
it actually creates a directory called `tmp` in the root of your main drive. It 
even takes care of the slashes itself.

Totally sweet, right?


- Alex Clemmer


On Oct. 22, 2015, 3:35 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39539/
> ---
> 
> (Updated Oct. 22, 2015, 3:35 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Moved `os::mktemp` to its own file, `stout/os/mktemp.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> ba2836a72ceee948cb43364e80ada9f132f33d04 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 7f70c9ea7d57634b5bfd40523ba37561ec92a09a 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/mktemp.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 
> 7a8819541506f57f70a9b577dc97a76fc26ebaa8 
> 
> Diff: https://reviews.apache.org/r/39539/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>