Re: Review Request 39560: CMake: Add state.cpp, flags.cpp to Windows agent build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39560/#review109662 --- Ship it! Ship It! - Joris Van Remoortere On Nov. 16, 2015, 9:13 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39560/ > --- > > (Updated Nov. 16, 2015, 9:13 a.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > --- > > CMake: Add state.cpp, flags.cpp to Windows agent build. > > > Diffs > - > > src/CMakeLists.txt a14518831553c5eb55fe648d349b91bb55e641d9 > > Diff: https://reviews.apache.org/r/39560/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 39560: CMake: Add state.cpp, flags.cpp to Windows agent build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39560/ --- (Updated Nov. 16, 2015, 9:13 a.m.) Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu. Repository: mesos Description --- CMake: Add state.cpp, flags.cpp to Windows agent build. Diffs (updated) - src/CMakeLists.txt a14518831553c5eb55fe648d349b91bb55e641d9 Diff: https://reviews.apache.org/r/39560/diff/ Testing --- Thanks, Alex Clemmer
Re: Review Request 39560: CMake: Add state.cpp, flags.cpp to Windows agent build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39560/#review104767 --- Ship it! Checked that this doesn't break the non-Windows CMake build. - Joseph Wu On Oct. 29, 2015, 10:54 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39560/ > --- > > (Updated Oct. 29, 2015, 10:54 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > --- > > CMake: Add state.cpp, flags.cpp to Windows agent build. > > > Diffs > - > > src/CMakeLists.txt d107e329cc6887cd9d4ce3706dfc6ce6080d0289 > > Diff: https://reviews.apache.org/r/39560/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 39560: CMake: Add state.cpp, flags.cpp to Windows agent build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39560/ --- (Updated Oct. 30, 2015, 5:54 a.m.) Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu. Repository: mesos Description --- CMake: Add state.cpp, flags.cpp to Windows agent build. Diffs (updated) - src/CMakeLists.txt d107e329cc6887cd9d4ce3706dfc6ce6080d0289 Diff: https://reviews.apache.org/r/39560/diff/ Testing --- Thanks, Alex Clemmer
Re: Review Request 39560: CMake: Add state.cpp, flags.cpp to Windows agent build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39560/#review103653 --- Patch looks great! Reviews applied: [39537, 39538, 39539, 39540, 39541, 39383, 39559, 39219, 39560] All tests passed. - Mesos ReviewBot On Oct. 22, 2015, 6:26 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39560/ > --- > > (Updated Oct. 22, 2015, 6:26 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > --- > > CMake: Add state.cpp, flags.cpp to Windows agent build. > > > Diffs > - > > src/CMakeLists.txt e6169a0e3ad34dd0e4c3430a6532bd48c4bd04fd > > Diff: https://reviews.apache.org/r/39560/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
