Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-13 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39595/ --- (Updated Nov. 13, 2015, 12:16 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-10 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39595/#review105881 --- Ship it! src/hdfs/hdfs.hpp (lines 205 - 210)

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-10 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39595/ --- (Updated Nov. 10, 2015, 4:14 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-10 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39595/ --- (Updated Nov. 10, 2015, 4:19 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39595/#review105870 --- Patch looks great! Reviews applied: [39594, 39595] All tests

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-10 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39595/#review105824 --- src/slave/containerizer/fetcher.hpp (line 252)

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-10 Thread Benjamin Bannier
> On Nov. 9, 2015, 1:01 p.m., Till Toenshoff wrote: > > src/hdfs/hdfs.hpp, lines 204-208 > > > > > > The examples of our doxygen-styleguide suggest that we should be using > > C style comments. Same goes with the

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-10 Thread Benjamin Bannier
> On Nov. 10, 2015, 12:52 p.m., Jan Schlicht wrote: > > src/slave/containerizer/fetcher.cpp, line 940 > > > > > > 4 spaces instead of 2 spaces. It appears that continuations for assignments are indented by 2

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39595/#review105857 --- Bad patch! Reviews applied: [39594] Failed command:

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-09 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39595/#review105587 --- src/hdfs/hdfs.hpp (lines 204 - 208)

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39595/#review105554 --- Patch looks great! Reviews applied: [39594, 39595] All tests

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39595/#review105551 --- Bad patch! Reviews applied: [39594] Failed command:

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-06 Thread Benjamin Bannier
> On Nov. 5, 2015, 1:29 p.m., Bernd Mathiske wrote: > > src/slave/containerizer/fetcher.cpp, line 254 > > > > > > Why no longer static? > > When you bring back static, you can also bring back the old param > >

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-06 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39595/ --- (Updated Nov. 6, 2015, 11:04 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-06 Thread Benjamin Bannier
> On Nov. 5, 2015, 1:29 p.m., Bernd Mathiske wrote: > > src/slave/containerizer/fetcher.cpp, line 276 > > > > > > An advanced compiler will figure out that this is a std::move just by > > itself (using escape

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-06 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39595/ --- (Updated Nov. 6, 2015, 7:52 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-06 Thread Benjamin Bannier
> On Nov. 5, 2015, 1:29 p.m., Bernd Mathiske wrote: > > src/slave/containerizer/fetcher.cpp, line 399 > > > > > > Since this is missing, we are now unconditionally relying on the URI > > being reachable. But why

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39595/#review105257 --- Patch looks great! Reviews applied: [39594, 39595] All tests

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-05 Thread Benjamin Bannier
> On Nov. 5, 2015, 1:29 p.m., Bernd Mathiske wrote: > > src/hdfs/hdfs.hpp, line 214 > > > > > > Please rebase and take this into account: > > > > https://issues.apache.org/jira/browse/MESOS-3602 > > >

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-11-05 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39595/ --- (Updated Nov. 5, 2015, 3:45 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 39595: Took mtime into account in the fetcher cache.

2015-10-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39595/#review103813 --- Patch looks great! Reviews applied: [39594, 39595] All tests