Re: Review Request 39621: CMake: Corrected linking path for gmock libraries on Windows builds.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39621/#review110026 --- Ship it! Ship It! - Joris Van Remoortere On Dec. 11, 2015, 8 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39621/ > --- > > (Updated Dec. 11, 2015, 8 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > --- > > CMake: Corrected linking path for gmock libraries on Windows builds. > > > Diffs > - > > 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake > 6eda46b0e08829b269b13a78f22510e6d03940d9 > > Diff: https://reviews.apache.org/r/39621/diff/ > > > Testing > --- > > `make check` from CMake on OS X 10.10. > `make check` from Autotools on OS X 10.10. > Ran `check` project in VS on Windows 10. > > PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH > into my Ubuntu box to test this from Ubuntu > > > Thanks, > > Alex Clemmer > >
Re: Review Request 39621: CMake: Corrected linking path for gmock libraries on Windows builds.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39621/ --- (Updated Dec. 11, 2015, 8 p.m.) Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu. Repository: mesos Description --- CMake: Corrected linking path for gmock libraries on Windows builds. Diffs (updated) - 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 6eda46b0e08829b269b13a78f22510e6d03940d9 Diff: https://reviews.apache.org/r/39621/diff/ Testing --- `make check` from CMake on OS X 10.10. `make check` from Autotools on OS X 10.10. Ran `check` project in VS on Windows 10. PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH into my Ubuntu box to test this from Ubuntu Thanks, Alex Clemmer
Re: Review Request 39621: CMake: Corrected linking path for gmock libraries on Windows builds.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39621/ --- (Updated Dec. 11, 2015, 6:11 p.m.) Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu. Repository: mesos Description --- CMake: Corrected linking path for gmock libraries on Windows builds. Diffs - 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 6eda46b0e08829b269b13a78f22510e6d03940d9 Diff: https://reviews.apache.org/r/39621/diff/ Testing --- `make check` from CMake on OS X 10.10. `make check` from Autotools on OS X 10.10. Ran `check` project in VS on Windows 10. PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH into my Ubuntu box to test this from Ubuntu Thanks, Alex Clemmer
Re: Review Request 39621: CMake: Corrected linking path for gmock libraries on Windows builds.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39621/ --- (Updated Nov. 16, 2015, 9:13 a.m.) Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu. Repository: mesos Description --- CMake: Corrected linking path for gmock libraries on Windows builds. Diffs (updated) - 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 6eda46b0e08829b269b13a78f22510e6d03940d9 Diff: https://reviews.apache.org/r/39621/diff/ Testing --- `make check` from CMake on OS X 10.10. `make check` from Autotools on OS X 10.10. Ran `check` project in VS on Windows 10. PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH into my Ubuntu box to test this from Ubuntu Thanks, Alex Clemmer
Re: Review Request 39621: CMake: Corrected linking path for gmock libraries on Windows builds.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39621/#review104773 --- Ship it! Ship It! - Joseph Wu On Oct. 29, 2015, 10:57 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39621/ > --- > > (Updated Oct. 29, 2015, 10:57 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > --- > > CMake: Corrected linking path for gmock libraries on Windows builds. > > > Diffs > - > > 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake > 6eda46b0e08829b269b13a78f22510e6d03940d9 > > Diff: https://reviews.apache.org/r/39621/diff/ > > > Testing > --- > > `make check` from CMake on OS X 10.10. > `make check` from Autotools on OS X 10.10. > Ran `check` project in VS on Windows 10. > > PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH > into my Ubuntu box to test this from Ubuntu > > > Thanks, > > Alex Clemmer > >
Re: Review Request 39621: CMake: Corrected linking path for gmock libraries on Windows builds.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39621/ --- (Updated Oct. 30, 2015, 5:57 a.m.) Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu. Repository: mesos Description --- CMake: Corrected linking path for gmock libraries on Windows builds. Diffs (updated) - 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 6eda46b0e08829b269b13a78f22510e6d03940d9 Diff: https://reviews.apache.org/r/39621/diff/ Testing --- `make check` from CMake on OS X 10.10. `make check` from Autotools on OS X 10.10. Ran `check` project in VS on Windows 10. PLEASE NOTE: I am on a terrible network with proxy problems and I can't SSH into my Ubuntu box to test this from Ubuntu Thanks, Alex Clemmer
