Re: Review Request 39818: Containerizer launcher: removed SSL environment.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39818/#review104628
---



src/slave/containerizer/containerizer.cpp (line 270)


As discussed with Jojy already, I think the problem is not that we included 
the SSL_ENABLED flag, but we actually didn't include them with the 
docker-executor launch.

We should instead add them if they're configured in the docker 
containerizer code.


- Timothy Chen


On Oct. 30, 2015, 4:14 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39818/
> ---
> 
> (Updated Oct. 30, 2015, 4:14 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Executor environment for the container need not include the SSL environment
> variables.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/containerizer.cpp 
> 06753365e2ec7cb59edd1ed6ecfe1a794498ee9b 
> 
> Diff: https://reviews.apache.org/r/39818/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39818: Containerizer launcher: removed SSL environment.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39818/#review104584
---


Patch looks great!

Reviews applied: [39818]

All tests passed.

- Mesos ReviewBot


On Oct. 30, 2015, 4:14 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39818/
> ---
> 
> (Updated Oct. 30, 2015, 4:14 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Executor environment for the container need not include the SSL environment
> variables.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/containerizer.cpp 
> 06753365e2ec7cb59edd1ed6ecfe1a794498ee9b 
> 
> Diff: https://reviews.apache.org/r/39818/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>