Re: Review Request 39843: Update declineOffer use Call::DECLINE to decline offer

2015-11-03 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39843/#review104971
---

Ship it!


Ship It!

- Vinod Kone


On Nov. 2, 2015, 9:42 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39843/
> ---
> 
> (Updated Nov. 2, 2015, 9:42 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3522
> https://issues.apache.org/jira/browse/MESOS-3522
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update declineOffer use Call::DECLINE to decline offer
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp 9c5e3b8e42605f4647d897ba02ea3a17e494f355 
>   src/tests/master_tests.cpp ee2473997ccbd1c50d0cbf65d1259ea2dfe82971 
> 
> Diff: https://reviews.apache.org/r/39843/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>



Re: Review Request 39843: Update declineOffer use Call::DECLINE to decline offer

2015-11-02 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39843/#review104699
---


Patch looks great!

Reviews applied: [39843]

All tests passed.

- Mesos ReviewBot


On Nov. 2, 2015, 9:42 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39843/
> ---
> 
> (Updated Nov. 2, 2015, 9:42 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3522
> https://issues.apache.org/jira/browse/MESOS-3522
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update declineOffer use Call::DECLINE to decline offer
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp 9c5e3b8e42605f4647d897ba02ea3a17e494f355 
>   src/tests/master_tests.cpp ee2473997ccbd1c50d0cbf65d1259ea2dfe82971 
> 
> Diff: https://reviews.apache.org/r/39843/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>



Re: Review Request 39843: Update declineOffer use Call::DECLINE to decline offer

2015-11-02 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39843/
---

(Updated Nov. 2, 2015, 9:42 a.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-3522
https://issues.apache.org/jira/browse/MESOS-3522


Repository: mesos


Description
---

Update declineOffer use Call::DECLINE to decline offer


Diffs (updated)
-

  src/sched/sched.cpp 9c5e3b8e42605f4647d897ba02ea3a17e494f355 
  src/tests/master_tests.cpp ee2473997ccbd1c50d0cbf65d1259ea2dfe82971 

Diff: https://reviews.apache.org/r/39843/diff/


Testing
---

make
make check


Thanks,

Guangya Liu



Re: Review Request 39843: Update declineOffer use Call::DECLINE to decline offer

2015-11-02 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39843/#review104684
---


Patch looks great!

Reviews applied: [39843]

All tests passed.

- Mesos ReviewBot


On Nov. 2, 2015, 8:30 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39843/
> ---
> 
> (Updated Nov. 2, 2015, 8:30 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3522
> https://issues.apache.org/jira/browse/MESOS-3522
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update declineOffer use Call::DECLINE to decline offer
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp 9c5e3b8e42605f4647d897ba02ea3a17e494f355 
>   src/tests/master_tests.cpp ee2473997ccbd1c50d0cbf65d1259ea2dfe82971 
> 
> Diff: https://reviews.apache.org/r/39843/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>



Re: Review Request 39843: Update declineOffer use Call::DECLINE to decline offer

2015-11-02 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39843/
---

(Updated εδΈ€ζœˆ 2, 2015, 8:30 a.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-3522
https://issues.apache.org/jira/browse/MESOS-3522


Repository: mesos


Description (updated)
---

Update declineOffer use Call::DECLINE to decline offer


Diffs (updated)
-

  src/sched/sched.cpp 9c5e3b8e42605f4647d897ba02ea3a17e494f355 
  src/tests/master_tests.cpp ee2473997ccbd1c50d0cbf65d1259ea2dfe82971 

Diff: https://reviews.apache.org/r/39843/diff/


Testing
---

make
make check


Thanks,

Guangya Liu