Re: Review Request 39886: Added documentation about roles.

2015-11-06 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39886/#review105393 --- Ship it! Remove the unrelated configuration.md changes and I'll

Re: Review Request 39886: Added documentation about roles.

2015-11-06 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39886/ --- (Updated Nov. 6, 2015, 6:04 p.m.) Review request for mesos and Adam B.

Re: Review Request 39886: Added documentation about roles.

2015-11-06 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39886/ --- (Updated Nov. 6, 2015, 6:08 p.m.) Review request for mesos and Adam B. Bugs:

Re: Review Request 39886: Added documentation about roles.

2015-11-05 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39886/#review105221 --- docs/roles.md (line 60)

Re: Review Request 39886: Added documentation about roles.

2015-11-05 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39886/ --- (Updated Nov. 5, 2015, 5:42 p.m.) Review request for mesos and Adam B.

Re: Review Request 39886: Added documentation about roles.

2015-11-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39886/#review105295 --- Patch looks great! Reviews applied: [39886] All tests passed. -

Re: Review Request 39886: Added documentation about roles.

2015-11-05 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39886/#review105365 --- Ship it! Thanks Neil for the update! - Guangya Liu On εδΈ€ζœˆ 5,

Re: Review Request 39886: Added documentation about roles.

2015-11-03 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39886/#review104884 --- docs/roles.md (line 10)

Re: Review Request 39886: Added documentation about roles.

2015-11-03 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39886/#review104893 --- Great start. I agree with AlexR that the hierarchical DRF use of

Re: Review Request 39886: Added documentation about roles.

2015-11-03 Thread Neil Conway
> On Nov. 3, 2015, 8:43 a.m., Alexander Rukletsov wrote: > > docs/roles.md, line 12 > > > > > > Do you want to be consistent with the existing codebase and continue > > use "slave" for now? We already use "agent"

Re: Review Request 39886: Added documentation about roles.

2015-11-03 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39886/ --- (Updated Nov. 3, 2015, 7:51 p.m.) Review request for mesos and Adam B.

Re: Review Request 39886: Added documentation about roles.

2015-11-03 Thread Neil Conway
> On Nov. 3, 2015, 2:40 a.m., Guangya Liu wrote: > > docs/attributes-resources.md, line 49 > > > > > > MESOS-3177 is planning to enable adding role dynamically, we may need > > to add a TODO here to reflect this.

Re: Review Request 39886: Added documentation about roles.

2015-11-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39886/#review104977 --- Patch looks great! Reviews applied: [39886] All tests passed. -

Re: Review Request 39886: Added documentation about roles.

2015-11-02 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39886/#review104847 --- Lots more we could discuss: ACLs, more details on DRF, etc. -- but

Re: Review Request 39886: Added documentation about roles.

2015-11-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39886/#review104849 --- docs/attributes-resources.md (line 49)

Re: Review Request 39886: Added documentation about roles.

2015-11-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39886/#review104868 --- Patch looks great! Reviews applied: [39886] All tests passed. -