Re: Review Request 39923: Cleaned up configuration.md.

2016-01-06 Thread Guangya Liu
> On 一月 6, 2016, 12:26 a.m., Neil Conway wrote: > > This introduces some inconsistencies between the text in `configuration.md` > > and the content of the various `flags.cpp` files (first thing I checked: > > "api" still appears in `src/logging/flags.cpp` but we now use "API" in > >

Re: Review Request 39923: Cleaned up configuration.md.

2016-01-05 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39923/ --- (Updated Jan. 5, 2016, 6:52 p.m.) Review request for mesos, Jojy Varghese,

Re: Review Request 39923: Cleaned up configuration.md.

2016-01-05 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39923/ --- (Updated Jan. 5, 2016, 7:53 p.m.) Review request for mesos, Jojy Varghese,

Re: Review Request 39923: Cleaned up configuration.md.

2016-01-05 Thread Guangya Liu
> On 一月 6, 2016, 12:26 a.m., Neil Conway wrote: > > This introduces some inconsistencies between the text in `configuration.md` > > and the content of the various `flags.cpp` files (first thing I checked: > > "api" still appears in `src/logging/flags.cpp` but we now use "API" in > >

Re: Review Request 39923: Cleaned up configuration.md.

2016-01-05 Thread Till Toenshoff
> On Dec. 7, 2015, 9:42 p.m., Neil Conway wrote: > > What is the status of this patch -- can someone (Till) commit it? > > Greg Mann wrote: > Looks like this is in need of a rebase, I'll update it. Sry, did not have it on my radar -- it's always a good idea to add me as a reviewer for

Re: Review Request 39923: Cleaned up configuration.md.

2016-01-05 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39923/#review112974 --- This introduces some inconsistencies between the text in

Re: Review Request 39923: Cleaned up configuration.md.

2015-12-14 Thread Greg Mann
> On Dec. 7, 2015, 9:42 p.m., Neil Conway wrote: > > What is the status of this patch -- can someone (Till) commit it? Looks like this is in need of a rebase, I'll update it. - Greg --- This is an automatically generated e-mail. To

Re: Review Request 39923: Cleaned up configuration.md.

2015-12-07 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39923/#review109192 --- What is the status of this patch -- can someone (Till) commit it?

Re: Review Request 39923: Cleaned up configuration.md.

2015-11-07 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39923/#review105585 --- Ship it! Ship It! - Till Toenshoff On Nov. 7, 2015, 12:20

Re: Review Request 39923: Cleaned up configuration.md.

2015-11-06 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39923/ --- (Updated Nov. 7, 2015, 12:20 a.m.) Review request for mesos, Jojy Varghese,

Re: Review Request 39923: Cleaned up configuration.md.

2015-11-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39923/#review105569 --- Bad patch! Reviews applied: [39923] Failed command:

Re: Review Request 39923: Cleaned up configuration.md.

2015-11-03 Thread Greg Mann
> On Nov. 4, 2015, 12:29 a.m., Guangya Liu wrote: > > docs/configuration.md, line 792 > > > > > > Why remove this? The text already states "A path to a file containing either one of the above options.", and I

Re: Review Request 39923: Cleaned up configuration.md.

2015-11-03 Thread Guangya Liu
> On 十一月 4, 2015, 12:29 a.m., Guangya Liu wrote: > > docs/configuration.md, line 792 > > > > > > Why remove this? > > Greg Mann wrote: > The text already states "A path to a file containing either one of the >

Re: Review Request 39923: Cleaned up configuration.md.

2015-11-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39923/#review105033 --- Patch looks great! Reviews applied: [39923] All tests passed. -