Re: Review Request 40062: MESIS-2315 Deprecate/Remove CommandInfo::ContainerInfo

2015-11-08 Thread Vaibhav Khanduja

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40062/
---

(Updated Nov. 9, 2015, 1:06 a.m.)


Review request for mesos and Adam B.


Changes
---

Added bug number


Bugs: MESOS-2315
https://issues.apache.org/jira/browse/MESOS-2315


Repository: mesos


Description
---

MESIS-2315 Deprecate/Remove CommandInfo::ContainerInfo


Diffs
-

  include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b 
  src/slave/containerizer/mesos/containerizer.cpp 
08243b61c1c277da7609bc910323cc1e27ff5cd4 
  src/slave/slave.cpp 535adc3b17d5af3fe811a8e2505f126a28212dbf 
  src/tests/slave_tests.cpp ddd01104d044b54664b3b1eefdde3f73b8f6d598 

Diff: https://reviews.apache.org/r/40062/diff/


Testing
---

sudo make check


Thanks,

Vaibhav Khanduja



Re: Review Request 40062: MESIS-2315 Deprecate/Remove CommandInfo::ContainerInfo

2015-11-08 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40062/#review105631
---


Bad patch!

Reviews applied: [40062]

Failed command: ./support/apply-review.sh -n -r 40062

Error:
 2015-11-09 00:53:55 URL:https://reviews.apache.org/r/40062/diff/raw/ 
[3762/3762] -> "40062.patch" [1]
error: patch failed: src/slave/slave.cpp:3341
error: src/slave/slave.cpp: patch does not apply
error: patch failed: src/tests/slave_tests.cpp:618
error: src/tests/slave_tests.cpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Nov. 9, 2015, 12:26 a.m., Vaibhav Khanduja wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40062/
> ---
> 
> (Updated Nov. 9, 2015, 12:26 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESIS-2315 Deprecate/Remove CommandInfo::ContainerInfo
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 08243b61c1c277da7609bc910323cc1e27ff5cd4 
>   src/slave/slave.cpp 535adc3b17d5af3fe811a8e2505f126a28212dbf 
>   src/tests/slave_tests.cpp ddd01104d044b54664b3b1eefdde3f73b8f6d598 
> 
> Diff: https://reviews.apache.org/r/40062/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Vaibhav Khanduja
> 
>