Re: Review Request 40115: Windows: Added support for `slave/gc.cpp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40115/#review121552 --- Ship it! - Joris Van Remoortere On March 1, 2016, 11:55 p.m., Daniel Pravat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40115/ > --- > > (Updated March 1, 2016, 11:55 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > Windows: Added support for `slave/gc.cpp`. > > > Diffs > - > > src/CMakeLists.txt 5cf0ec8c475839ad8717192a37f01546cbcccd7a > src/slave/gc.cpp 7a8c69b4410df46ca8fd6ac009cc14e8fe5ff6d3 > > Diff: https://reviews.apache.org/r/40115/diff/ > > > Testing > --- > > Windows 10: make.bat > OSX: make check > Ubuntu: 15.1 make check > > > Thanks, > > Daniel Pravat > >
Re: Review Request 40115: Windows: Added support for `slave/gc.cpp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40115/ --- (Updated March 1, 2016, 11:54 p.m.) Review request for mesos, Alex Naparu, Alex Clemmer, M Lawindi, and Yi Sun. Repository: mesos Description (updated) --- Windows: Added support for `slave/gc.cpp`. Diffs (updated) - src/CMakeLists.txt 5cf0ec8c475839ad8717192a37f01546cbcccd7a src/slave/gc.cpp 7a8c69b4410df46ca8fd6ac009cc14e8fe5ff6d3 Diff: https://reviews.apache.org/r/40115/diff/ Testing --- Windows 10: make.bat OSX: make check Ubuntu: 15.1 make check Thanks, Daniel Pravat
Re: Review Request 40115: Windows: Added support for `slave/gc.cpp`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40115/ --- (Updated Jan. 14, 2016, 1:15 a.m.) Review request for Alex Naparu and Alex Clemmer. Summary (updated) - Windows: Added support for `slave/gc.cpp`. Repository: mesos Description (updated) --- Windows: Added support for `slave/gc.cpp`. Diffs - src/CMakeLists.txt 0d46043dd06007f2cba56626c82e8edd251cb8fb src/slave/gc.cpp 7a8c69b4410df46ca8fd6ac009cc14e8fe5ff6d3 Diff: https://reviews.apache.org/r/40115/diff/ Testing --- Windows 10: make.bat OSX: make check Ubuntu: 15.1 make check Thanks, Daniel Pravat
Re: Review Request 40115: Windows: Added support for `slave/gc.cpp'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40115/ --- (Updated Dec. 23, 2015, 7:22 a.m.) Review request for Alex Naparu and Alex Clemmer. Repository: mesos Description --- Windows: Added support for `slave/gc.cpp'. Diffs (updated) - src/CMakeLists.txt 0d46043dd06007f2cba56626c82e8edd251cb8fb src/slave/gc.cpp 7a8c69b4410df46ca8fd6ac009cc14e8fe5ff6d3 Diff: https://reviews.apache.org/r/40115/diff/ Testing --- Windows 10: make.bat OSX: make check Ubuntu: 15.1 make check Thanks, Daniel Pravat
Re: Review Request 40115: Windows: Added support for `slave/gc.cpp'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40115/ --- (Updated Dec. 22, 2015, 7:32 a.m.) Review request for Alex Naparu and Alex Clemmer. Repository: mesos Description --- Windows: Added support for `slave/gc.cpp'. Diffs (updated) - src/CMakeLists.txt 0d46043dd06007f2cba56626c82e8edd251cb8fb src/slave/gc.cpp 7a8c69b4410df46ca8fd6ac009cc14e8fe5ff6d3 Diff: https://reviews.apache.org/r/40115/diff/ Testing --- Windows 10: make.bat OSX: make check Ubuntu: 15.1 make check Thanks, Daniel Pravat
Re: Review Request 40115: Windows: Added support for `slave/gc.cpp'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40115/#review108597 --- Bad patch! Reviews applied: [40114, 39537, 39538, 39539, 39540, 39541, 39383, 39559, 39219] Failed command: ./support/apply-review.sh -n -r 39219 Error: 2015-12-02 02:20:21 URL:https://reviews.apache.org/r/39219/diff/raw/ [3137/3137] -> "39219.patch" [1] error: patch failed: src/slave/state.cpp:16 error: src/slave/state.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On Dec. 1, 2015, 9:06 p.m., Daniel Pravat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40115/ > --- > > (Updated Dec. 1, 2015, 9:06 p.m.) > > > Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van > Remoortere, and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Windows: Added support for `slave/gc.cpp'. > > > Diffs > - > > src/CMakeLists.txt cfe9d26c45ba42852fd1af958549954e7b04d448 > src/slave/gc.cpp 7a8c69b4410df46ca8fd6ac009cc14e8fe5ff6d3 > > Diff: https://reviews.apache.org/r/40115/diff/ > > > Testing > --- > > Windows 10: make.bat > OSX: make check > Ubuntu: 15.1 make check > > > Thanks, > > Daniel Pravat > >
Re: Review Request 40115: Windows: Added support for `slave/gc.cpp'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40115/ --- (Updated Dec. 1, 2015, 9:06 p.m.) Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Repository: mesos Description --- Windows: Added support for `slave/gc.cpp'. Diffs (updated) - src/CMakeLists.txt cfe9d26c45ba42852fd1af958549954e7b04d448 src/slave/gc.cpp 7a8c69b4410df46ca8fd6ac009cc14e8fe5ff6d3 Diff: https://reviews.apache.org/r/40115/diff/ Testing --- Windows 10: make.bat OSX: make check Ubuntu: 15.1 make check Thanks, Daniel Pravat
Re: Review Request 40115: Windows: Added support for `slave/gc.cpp'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40115/ --- (Updated Nov. 28, 2015, 7:16 a.m.) Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Changes --- Fixed the patch to eliminate unecessary dependency. Repository: mesos Description --- Windows: Added support for `slave/gc.cpp'. Diffs (updated) - src/CMakeLists.txt 9a2c70d40031c80a304462107758802c08411a49 src/slave/gc.cpp 6042277f893a54ada612b2080d35061236f4176a Diff: https://reviews.apache.org/r/40115/diff/ Testing --- Windows 10: make.bat OSX: make check Ubuntu: 15.1 make check Thanks, Daniel Pravat
Re: Review Request 40115: Windows: Added support for `slave/gc.cpp'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40115/#review107953 --- Bad patch! Reviews applied: [40114, 40115] Failed command: ./support/apply-review.sh -n -r 40115 Error: 2015-11-25 09:07:15 URL:https://reviews.apache.org/r/40115/diff/raw/ [815/815] -> "40115.patch" [1] error: patch failed: src/CMakeLists.txt:167 error: src/CMakeLists.txt: patch does not apply Failed to apply patch - Mesos ReviewBot On Nov. 24, 2015, 9:57 p.m., Daniel Pravat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40115/ > --- > > (Updated Nov. 24, 2015, 9:57 p.m.) > > > Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van > Remoortere, and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Windows: Added support for `slave/gc.cpp'. > > > Diffs > - > > src/CMakeLists.txt a14518831553c5eb55fe648d349b91bb55e641d9 > src/slave/gc.cpp 6042277f893a54ada612b2080d35061236f4176a > > Diff: https://reviews.apache.org/r/40115/diff/ > > > Testing > --- > > Windows 10: make.bat > OSX: make check > Ubuntu: 15.1 make check > > > Thanks, > > Daniel Pravat > >
Re: Review Request 40115: Windows: Added support for `slave/gc.cpp'.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40115/ --- (Updated Nov. 24, 2015, 9:57 p.m.) Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Joseph Wu. Repository: mesos Description --- Windows: Added support for `slave/gc.cpp'. Diffs - src/CMakeLists.txt a14518831553c5eb55fe648d349b91bb55e641d9 src/slave/gc.cpp 6042277f893a54ada612b2080d35061236f4176a Diff: https://reviews.apache.org/r/40115/diff/ Testing --- Windows 10: make.bat OSX: make check Ubuntu: 15.1 make check Thanks, Daniel Pravat
