Re: Review Request 40142: Corrected include order for gtest and gmock according to Styleguide.

2015-11-10 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40142/ --- (Updated Nov. 10, 2015, 5:22 p.m.) Review request for mesos and Jan Schlicht.

Re: Review Request 40142: Corrected include order for gtest and gmock according to Styleguide.

2015-11-10 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40142/#review105898 --- Ship it! Ship It! - Jan Schlicht On Nov. 10, 2015, 6:14 p.m.,

Re: Review Request 40142: Corrected include order for gtest and gmock according to Styleguide.

2015-11-10 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40142/ --- (Updated Nov. 10, 2015, 5:14 p.m.) Review request for mesos and Jan Schlicht.

Re: Review Request 40142: Corrected include order for gtest and gmock according to Styleguide.

2015-11-10 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40142/ --- (Updated Nov. 10, 2015, 5:13 p.m.) Review request for mesos and Jan Schlicht.

Re: Review Request 40142: Corrected include order for gtest and gmock according to Styleguide.

2015-11-10 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40142/ --- (Updated Nov. 10, 2015, 6:30 p.m.) Review request for mesos and Jan Schlicht.

Re: Review Request 40142: Corrected include order for gtest and gmock according to Styleguide.

2015-11-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40142/#review105904 --- Bad patch! Reviews applied: [40142] Failed command:

Re: Review Request 40142: Corrected include order for gtest and gmock according to Styleguide.

2015-11-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40142/#review105910 --- Patch looks great! Reviews applied: [40142] All tests passed. -

Re: Review Request 40142: Corrected include order for gtest and gmock according to Styleguide.

2015-11-10 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40142/#review105981 --- src/tests/containerizer.hpp (line 19)

Re: Review Request 40142: Corrected include order for gtest and gmock according to Styleguide.

2015-11-10 Thread Joerg Schad
> On Nov. 10, 2015, 10:41 p.m., Guangya Liu wrote: > > src/tests/containerizer.hpp, line 19 > > > > > > I see that we have some discussion in mail list, can you please add > > more detail for what we discussed in

Re: Review Request 40142: Corrected include order for gtest and gmock according to Styleguide.

2015-11-10 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40142/#review106002 --- Ship it! Given that gmock ist not (and never should be, according

Re: Review Request 40142: Corrected include order for gtest and gmock according to Styleguide.

2015-11-10 Thread Guangya Liu
> On Nov. 10, 2015, 10:41 p.m., Guangya Liu wrote: > > src/tests/containerizer.hpp, line 19 > > > > > > I see that we have some discussion in mail list, can you please add > > more detail for what we discussed in