Re: Review Request 40199: Fix CMake build.

2015-11-11 Thread Jojy Varghese

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40199/#review106151
---

Ship it!


Ship It!

- Jojy Varghese


On Nov. 11, 2015, 9:09 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40199/
> ---
> 
> (Updated Nov. 11, 2015, 9:09 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Error introduced in https://reviews.apache.org/r/38580/diff/25#0.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt c235209743de6e84deb44df31c61948f4dc8b8eb 
> 
> Diff: https://reviews.apache.org/r/40199/diff/
> 
> 
> Testing
> ---
> 
> ```
> cmake ..
> make check
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Re: Review Request 40199: Fix CMake build.

2015-11-11 Thread Gilbert Song

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40199/#review106152
---

Ship it!


Ship It!

- Gilbert Song


On Nov. 11, 2015, 1:09 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40199/
> ---
> 
> (Updated Nov. 11, 2015, 1:09 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Error introduced in https://reviews.apache.org/r/38580/diff/25#0.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt c235209743de6e84deb44df31c61948f4dc8b8eb 
> 
> Diff: https://reviews.apache.org/r/40199/diff/
> 
> 
> Testing
> ---
> 
> ```
> cmake ..
> make check
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Re: Review Request 40199: Fix CMake build.

2015-11-11 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40199/#review106157
---


Patch looks great!

Reviews applied: [40199]

All tests passed.

- Mesos ReviewBot


On Nov. 11, 2015, 9:09 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40199/
> ---
> 
> (Updated Nov. 11, 2015, 9:09 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Error introduced in https://reviews.apache.org/r/38580/diff/25#0.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt c235209743de6e84deb44df31c61948f4dc8b8eb 
> 
> Diff: https://reviews.apache.org/r/40199/diff/
> 
> 
> Testing
> ---
> 
> ```
> cmake ..
> make check
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Re: Review Request 40199: Fix CMake build.

2015-11-11 Thread Timothy Chen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40199/#review106158
---

Ship it!


Ship It!

- Timothy Chen


On Nov. 11, 2015, 9:09 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40199/
> ---
> 
> (Updated Nov. 11, 2015, 9:09 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Error introduced in https://reviews.apache.org/r/38580/diff/25#0.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt c235209743de6e84deb44df31c61948f4dc8b8eb 
> 
> Diff: https://reviews.apache.org/r/40199/diff/
> 
> 
> Testing
> ---
> 
> ```
> cmake ..
> make check
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Re: Review Request 40199: Fix CMake build.

2015-11-11 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40199/#review106162
---


Patch looks great!

Reviews applied: [40199]

All tests passed.

- Mesos ReviewBot


On Nov. 11, 2015, 9:09 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40199/
> ---
> 
> (Updated Nov. 11, 2015, 9:09 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Error introduced in https://reviews.apache.org/r/38580/diff/25#0.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt c235209743de6e84deb44df31c61948f4dc8b8eb 
> 
> Diff: https://reviews.apache.org/r/40199/diff/
> 
> 
> Testing
> ---
> 
> ```
> cmake ..
> make check
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>