Re: Review Request 40214: Cleaned up protobuf generation rules in src/Makefile.am.

2015-11-12 Thread Jie Yu
> On Nov. 12, 2015, 5:26 p.m., Vinod Kone wrote: > > src/Makefile.am, lines 171-177 > > > > > > just curious why we had LOG_PROTOS and STATE_PROTOS pointing to the C > > files instead of LOG_PROTO and STATE_PROTO po

Re: Review Request 40214: Cleaned up protobuf generation rules in src/Makefile.am.

2015-11-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40214/#review106271 --- Ship it! src/Makefile.am (lines 163 - 169)

Re: Review Request 40214: Cleaned up protobuf generation rules in src/Makefile.am.

2015-11-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40214/#review106193 --- Patch looks great! Reviews applied: [40214] All tests passed. -

Re: Review Request 40214: Cleaned up protobuf generation rules in src/Makefile.am.

2015-11-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40214/#review106192 --- Patch looks great! Reviews applied: [40214] All tests passed. -