Re: Review Request 40243: Documented "role" field in Resource protobuf message.

2015-11-23 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40243/
---

(Updated Nov. 23, 2015, 11:44 a.m.)


Review request for mesos, Greg Mann and Michael Park.


Changes
---

Rebase.


Bugs: MESOS-2455
https://issues.apache.org/jira/browse/MESOS-2455


Repository: mesos


Description
---

Documented "role" field in Resource protobuf message.


Diffs (updated)
-

  include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b 
  include/mesos/v1/mesos.proto e71ddda7f23f2272ce8eb00f358c66fce205c13b 

Diff: https://reviews.apache.org/r/40243/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 40243: Documented "role" field in Resource protobuf message.

2015-11-21 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40243/#review107486
---

Ship it!


Ship It!

- Guangya Liu


On 十一月 20, 2015, 10:31 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40243/
> ---
> 
> (Updated 十一月 20, 2015, 10:31 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented "role" field in Resource protobuf message.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b 
>   include/mesos/v1/mesos.proto e71ddda7f23f2272ce8eb00f358c66fce205c13b 
> 
> Diff: https://reviews.apache.org/r/40243/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40243: Documented "role" field in Resource protobuf message.

2015-11-20 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40243/
---

(Updated Nov. 20, 2015, 10:31 p.m.)


Review request for mesos, Greg Mann and Michael Park.


Changes
---

Rebase.


Bugs: MESOS-2455
https://issues.apache.org/jira/browse/MESOS-2455


Repository: mesos


Description
---

Documented "role" field in Resource protobuf message.


Diffs (updated)
-

  include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b 
  include/mesos/v1/mesos.proto e71ddda7f23f2272ce8eb00f358c66fce205c13b 

Diff: https://reviews.apache.org/r/40243/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 40243: Documented "role" field in Resource protobuf message.

2015-11-18 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40243/#review107098
---

Ship it!


Ship It!

- Greg Mann


On Nov. 18, 2015, 11:28 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40243/
> ---
> 
> (Updated Nov. 18, 2015, 11:28 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented "role" field in Resource protobuf message.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b 
>   include/mesos/v1/mesos.proto e71ddda7f23f2272ce8eb00f358c66fce205c13b 
> 
> Diff: https://reviews.apache.org/r/40243/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40243: Documented "role" field in Resource protobuf message.

2015-11-18 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40243/
---

(Updated Nov. 18, 2015, 11:28 a.m.)


Review request for mesos, Greg Mann and Michael Park.


Changes
---

Address mpark's comments.


Bugs: MESOS-2455
https://issues.apache.org/jira/browse/MESOS-2455


Repository: mesos


Description
---

Documented "role" field in Resource protobuf message.


Diffs (updated)
-

  include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b 
  include/mesos/v1/mesos.proto e71ddda7f23f2272ce8eb00f358c66fce205c13b 

Diff: https://reviews.apache.org/r/40243/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 40243: Documented "role" field in Resource protobuf message.

2015-11-18 Thread Neil Conway 


> On Nov. 18, 2015, 12:02 a.m., Michael Park wrote:
> > include/mesos/mesos.proto, line 583
> > 
> >
> > How about `The role that this resource is reserved for.`? In the sense 
> > that it's not the role that reserves a resource, per se.

Yes, definitely better!


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40243/#review106962
---


On Nov. 13, 2015, 12:45 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40243/
> ---
> 
> (Updated Nov. 13, 2015, 12:45 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented "role" field in Resource protobuf message.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b 
>   include/mesos/v1/mesos.proto e71ddda7f23f2272ce8eb00f358c66fce205c13b 
> 
> Diff: https://reviews.apache.org/r/40243/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40243: Documented "role" field in Resource protobuf message.

2015-11-17 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40243/#review106962
---

Ship it!



include/mesos/mesos.proto (line 583)


How about `The role that this resource is reserved for.`? In the sense that 
it's not the role that reserves a resource, per se.


- Michael Park


On Nov. 13, 2015, 12:45 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40243/
> ---
> 
> (Updated Nov. 13, 2015, 12:45 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented "role" field in Resource protobuf message.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b 
>   include/mesos/v1/mesos.proto e71ddda7f23f2272ce8eb00f358c66fce205c13b 
> 
> Diff: https://reviews.apache.org/r/40243/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40243: Documented "role" field in Resource protobuf message.

2015-11-13 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40243/
---

(Updated Nov. 13, 2015, 12:45 p.m.)


Review request for mesos, Greg Mann and Michael Park.


Bugs: MESOS-2455
https://issues.apache.org/jira/browse/MESOS-2455


Repository: mesos


Description
---

Documented "role" field in Resource protobuf message.


Diffs (updated)
-

  include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b 
  include/mesos/v1/mesos.proto e71ddda7f23f2272ce8eb00f358c66fce205c13b 

Diff: https://reviews.apache.org/r/40243/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 40243: Documented "role" field in Resource protobuf message.

2015-11-13 Thread Neil Conway 


> On Nov. 13, 2015, 3:02 a.m., Guangya Liu wrote:
> > include/mesos/mesos.proto, lines 583-585
> > 
> >
> > I think that the v1 part should also be updated

Good catch! Thanks.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40243/#review106358
---


On Nov. 13, 2015, 12:45 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40243/
> ---
> 
> (Updated Nov. 13, 2015, 12:45 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented "role" field in Resource protobuf message.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b 
>   include/mesos/v1/mesos.proto e71ddda7f23f2272ce8eb00f358c66fce205c13b 
> 
> Diff: https://reviews.apache.org/r/40243/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40243: Documented "role" field in Resource protobuf message.

2015-11-12 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40243/#review106358
---



include/mesos/mesos.proto (lines 583 - 585)


I think that the v1 part should also be updated


- Guangya Liu


On 十一月 12, 2015, 5:59 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40243/
> ---
> 
> (Updated 十一月 12, 2015, 5:59 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented "role" field in Resource protobuf message.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b 
> 
> Diff: https://reviews.apache.org/r/40243/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>