Re: Review Request 40268: [WIP] Libprocess Reinitialization: Change Socket::DEFAULT_KIND to return a non-static local value.
> On Nov. 19, 2015, 1:33 p.m., Vinod Kone wrote: > > i'm discarding this review to unblock review bot -- @vinodkone Oops, I didn't know that reviewbot would get stuck on a (dangling?) review like this :) - Joseph --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40268/#review107242 --- On Nov. 18, 2015, 1:52 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40268/ > --- > > (Updated Nov. 18, 2015, 1:52 p.m.) > > > Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. > > > Bugs: MESOS-3820 > https://issues.apache.org/jira/browse/MESOS-3820 > > > Repository: mesos > > > Description > --- > > This is only needed for tests that utilize the test-only > `process::reinitialize` function. > > Note: This is part of a review chain draft, so ignore any links in "Depends > On" or "Blocks". This commit revealed some incomplete cleanup in tests, > which is fixed here: > https://reviews.apache.org/r/40453/ > > > Diffs > - > > 3rdparty/libprocess/include/process/socket.hpp > ebee78909feb5a4032da68f51d08dbf11b03b332 > 3rdparty/libprocess/src/socket.cpp 6ac834e7459f5958b7c788ccdc60cbed90530183 > > Diff: https://reviews.apache.org/r/40268/diff/ > > > Testing > --- > > > Thanks, > > Joseph Wu > >
Re: Review Request 40268: [WIP] Libprocess Reinitialization: Change Socket::DEFAULT_KIND to return a non-static local value.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40268/#review107242 --- i'm discarding this review to unblock review bot -- @vinodkone - Vinod Kone On Nov. 18, 2015, 9:52 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40268/ > --- > > (Updated Nov. 18, 2015, 9:52 p.m.) > > > Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. > > > Bugs: MESOS-3820 > https://issues.apache.org/jira/browse/MESOS-3820 > > > Repository: mesos > > > Description > --- > > This is only needed for tests that utilize the test-only > `process::reinitialize` function. > > Note: This is part of a review chain draft, so ignore any links in "Depends > On" or "Blocks". This commit revealed some incomplete cleanup in tests, > which is fixed here: > https://reviews.apache.org/r/40453/ > > > Diffs > - > > 3rdparty/libprocess/include/process/socket.hpp > ebee78909feb5a4032da68f51d08dbf11b03b332 > 3rdparty/libprocess/src/socket.cpp 6ac834e7459f5958b7c788ccdc60cbed90530183 > > Diff: https://reviews.apache.org/r/40268/diff/ > > > Testing > --- > > > Thanks, > > Joseph Wu > >
