Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

2015-12-03 Thread Alexander Rukletsov
> On Nov. 23, 2015, 5:54 p.m., Joris Van Remoortere wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 413-418 > > > > > > Rather than doing the math here (which I believe we're missing > >

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

2015-12-03 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40332/ --- (Updated Dec. 3, 2015, 8:07 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

2015-12-03 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40332/ --- (Updated Dec. 3, 2015, 9:10 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

2015-12-03 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40332/#review108925 --- Ship it! Ship It! - Joris Van Remoortere On Dec. 3, 2015, 9:10

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

2015-12-01 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40332/#review108615 --- Ship it! Ship It! - Qian Zhang On Nov. 30, 2015, 11:32 p.m.,

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

2015-11-30 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40332/ --- (Updated Nov. 30, 2015, 3:32 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

2015-11-24 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40332/ --- (Updated Nov. 24, 2015, 3:07 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

2015-11-23 Thread Joris Van Remoortere
> On Nov. 23, 2015, 2:40 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 171 > > > > > > What about rename it to recoverQuota()? We want to have just a single recover function, just

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

2015-11-23 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40332/ --- (Updated Nov. 23, 2015, 10:44 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

2015-11-23 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40332/#review107568 --- src/master/allocator/mesos/hierarchical.cpp (line 192)

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

2015-11-23 Thread Alexander Rukletsov
> On Nov. 23, 2015, 2:40 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 171 > > > > > > What about rename it to recoverQuota()? > > Joris Van Remoortere wrote: > We want to have

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

2015-11-23 Thread Alexander Rukletsov
> On Nov. 23, 2015, 9:22 a.m., Qian Zhang wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 192 > > > > > > I think what we want to use should be master's flag: > > `slave_reregister_timeout`, so can we

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

2015-11-23 Thread Alexander Rukletsov
> On Nov. 23, 2015, 5:54 p.m., Joris Van Remoortere wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 177-178 > > > > > > This first invariant is something we push on the user of the allocator > > API

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

2015-11-23 Thread Alexander Rukletsov
> On Nov. 23, 2015, 2:07 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 193 > > > > > > Can we add some comments for why using 0.8 as default? They should be exposed as parameters.

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

2015-11-23 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40332/ --- (Updated Nov. 23, 2015, 11:35 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

2015-11-23 Thread Guangya Liu
> On 十一月 23, 2015, 2:40 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 171 > > > > > > What about rename it to recoverQuota()? > > Joris Van Remoortere wrote: > We want to have

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

2015-11-23 Thread Guangya Liu
> On 十一月 23, 2015, 5:54 p.m., Joris Van Remoortere wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 191-193 > > > > > > Is there a ticket for this? I think we'll want to do this for the MVP. > >

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

2015-11-23 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40332/#review107692 --- src/master/allocator/mesos/hierarchical.cpp (line 416)

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

2015-11-23 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40332/ --- (Updated Nov. 23, 2015, 4:11 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

2015-11-23 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40332/#review107607 --- src/master/allocator/mesos/hierarchical.hpp (line 196)

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

2015-11-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40332/ --- (Updated Nov. 23, 2015, 12:31 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

2015-11-22 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40332/#review107535 --- src/master/allocator/mesos/hierarchical.cpp (line 193)

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

2015-11-22 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40332/#review107539 --- src/master/allocator/mesos/hierarchical.cpp (line 171)

Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.

2015-11-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40332/#review107543 --- Patch looks great! Reviews applied: [40332] Passed command: