Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40346/ --- (Updated Dec. 18, 2015, 10:09 a.m.) Review request for mesos, Alexander

Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40346/#review110928 --- Ship it! include/mesos/authorizer/authorizer.hpp (lines 177 -

Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

> On Dec. 17, 2015, 10:20 a.m., Joerg Schad wrote: > > include/mesos/authorizer/authorizer.hpp, lines 177-180 > > > > > > , otherwise ... (Consistent with the other comments) - Joerg

Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40346/ --- (Updated Dec. 17, 2015, 12:15 p.m.) Review request for mesos, Alexander

Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40346/#review110655 --- include/mesos/authorizer/authorizer.hpp (lines 177 - 180)

Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40346/ --- (Updated Dec. 15, 2015, 12:06 p.m.) Review request for mesos, Alexander

Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40346/#review110333 --- Ship it! include/mesos/authorizer/authorizer.hpp (line 187)

Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40346/#review110034 --- Looking good! Minor nit below.

Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40346/ --- (Updated Dec. 7, 2015, 11:32 a.m.) Review request for mesos, Alexander

Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40346/ --- (Updated Dec. 4, 2015, 3:34 p.m.) Review request for mesos, Alexander

Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40346/#review109053 --- Ship it! include/mesos/authorizer/authorizer.hpp (line 175)

Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40346/#review108637 --- Ship it! include/mesos/authorizer/authorizer.hpp (lines 136 -

Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

> On Nov. 16, 2015, 3:23 p.m., Joerg Schad wrote: > > src/tests/mesos.hpp, line 1245 > > > > > > This looks somehow weird... Who is satisfying the expect_call? > > Guangya Liu wrote: > I also have the same

Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40346/ --- (Updated Nov. 16, 2015, 4:48 p.m.) Review request for mesos, Alexander

Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40346/#review106660 --- include/mesos/authorizer/authorizer.hpp (line 136)

Re: Review Request 40346: [2/4] Quota Authorization: Implemented authorization of quota requests in the authorizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40346/ --- (Updated Nov. 16, 2015, 2:53 p.m.) Review request for mesos, Alexander