Re: Review Request 40497: Add hex number support to numify()

2015-11-30 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40497/ --- (Updated Nov. 30, 2015, 9:57 p.m.) Review request for mesos, Ben Mahler, Ian

Re: Review Request 40497: Add hex number support to numify()

2015-11-30 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40497/ --- (Updated Dec. 1, 2015, 12:17 a.m.) Review request for mesos, Ben Mahler, Ian

Re: Review Request 40497: Add hex number support to numify()

2015-11-30 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40497/#review108410 --- Ship it!

Re: Review Request 40497: Add hex number support to numify()

2015-11-23 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40497/ --- (Updated Nov. 23, 2015, 10:32 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 40497: Add hex number support to numify()

2015-11-23 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40497/#review107683 --- 3rdparty/libprocess/3rdparty/stout/tests/numify_tests.cpp (line

Re: Review Request 40497: Add hex number support to numify()

2015-11-22 Thread Cong Wang
> On Nov. 20, 2015, 3:23 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/numify.hpp, line 39 > > > > > > Where you planning to output `c` here? Otherwise I suggest replacing > >

Re: Review Request 40497: Add hex number support to numify()

2015-11-21 Thread Benjamin Bannier
> On Nov. 20, 2015, 3:23 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/numify.hpp, line 39 > > > > > > Where you planning to output `c` here? Otherwise I suggest replacing > >

Re: Review Request 40497: Add hex number support to numify()

2015-11-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40497/#review107370 --- 3rdparty/libprocess/3rdparty/stout/include/stout/numify.hpp (line

Re: Review Request 40497: Add hex number support to numify()

2015-11-20 Thread Cong Wang
> On Nov. 20, 2015, 3:23 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/numify.hpp, line 30 > > > > > > I believe giving these proper names would make e.g., the ordering here > >

Re: Review Request 40497: Add hex number support to numify()

2015-11-20 Thread Cong Wang
> On Nov. 20, 2015, 3:23 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/numify_tests.cpp, line 26 > > > > > > Would be nice to add a couple more positives here, e.g., to catch > >

Re: Review Request 40497: Add hex number support to numify()

2015-11-20 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40497/ --- (Updated Nov. 20, 2015, 10:26 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 40497: Add hex number support to numify()

2015-11-19 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40497/ --- (Updated Nov. 19, 2015, 10:56 p.m.) Review request for mesos, Ben Mahler and