Re: Review Request 40501: Cleanup a leaked reference to a test process living in the stack.

> On Dec. 3, 2015, 7:33 p.m., Ben Mahler wrote: > > src/tests/fetcher_tests.cpp, lines 285-289 > > > > > > This makes spawning and termination asymmetric! :( > > > > Please follow the approach done here: > >

Re: Review Request 40501: Cleanup a leaked reference to a test process living in the stack.

> On Dec. 3, 2015, 7:33 p.m., Ben Mahler wrote: > > src/tests/fetcher_tests.cpp, lines 285-289 > > > > > > This makes spawning and termination asymmetric! :( > > > > Please follow the approach done here: > >

Re: Review Request 40501: Cleanup a leaked reference to a test process living in the stack.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40501/#review108937 --- src/tests/fetcher_tests.cpp (lines 285 - 289)

Re: Review Request 40501: Cleanup a leaked reference to a test process living in the stack.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40501/#review107415 --- Patch looks great! Reviews applied: [40501] Passed command: expor

Re: Review Request 40501: Cleanup a leaked reference to a test process living in the stack.

> On Nov. 19, 2015, 6:16 p.m., Neil Conway wrote: > > Good find. I wonder: > > > > (a) is there some general advice we should give to people implementing > > Processes (e.g., "always provide a destructor that does terminate/wait" -- > > that is probably too broad though). Would be nice to add

Re: Review Request 40501: Cleanup a leaked reference to a test process living in the stack.

> On Nov. 20, 2015, 2:16 a.m., Neil Conway wrote: > > Good find. I wonder: > > > > (a) is there some general advice we should give to people implementing > > Processes (e.g., "always provide a destructor that does terminate/wait" -- > > that is probably too broad though). Would be nice to add

Re: Review Request 40501: Cleanup a leaked reference to a test process living in the stack.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40501/#review107301 --- Ship it! Great catach! - Bernd Mathiske On Nov. 19, 2015, 1:51

Re: Review Request 40501: Cleanup a leaked reference to a test process living in the stack.

> On Nov. 19, 2015, 6:16 p.m., Neil Conway wrote: > > Good find. I wonder: > > > > (a) is there some general advice we should give to people implementing > > Processes (e.g., "always provide a destructor that does terminate/wait" -- > > that is probably too broad though). Would be nice to add

Re: Review Request 40501: Cleanup a leaked reference to a test process living in the stack.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40501/#review107290 --- Ship it! Good find. I wonder: (a) is there some general advice we