Re: Review Request 40553: Enable mesos tests installation.

2016-02-08 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#review118233 --- Fix it, then Ship it! Thanks a bunch James, this looks great

Re: Review Request 40553: Enable mesos tests installation.

2016-02-08 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#review118249 --- src/tests/script.cpp (line 112)

Re: Review Request 40553: Enable mesos tests installation.

2016-02-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#review117871 --- Patch looks great! Reviews applied: [39780, 39781, 39782, 40553]

Re: Review Request 40553: Enable mesos tests installation.

2016-02-04 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/ --- (Updated Feb. 4, 2016, 6:14 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 40553: Enable mesos tests installation.

2016-01-27 Thread Benjamin Bannier
> On Jan. 27, 2016, 8:44 p.m., Benjamin Bannier wrote: > > Looks mostly good to me. A few things were unclear to me: > > > > * Would it make sense to add an `installcheck` target? My expectation for > > that would be for it to invoke the installed tests and adding the > > (in)correct

Re: Review Request 40553: Enable mesos tests installation.

2016-01-27 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#review116652 --- Fix it, then Ship it! src/Makefile.am (line 1999)

Re: Review Request 40553: Enable mesos tests installation.

2016-01-27 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/ --- (Updated Jan. 28, 2016, 12:49 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 40553: Enable mesos tests installation.

2016-01-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#review116714 --- Patch looks great! Reviews applied: [39780, 39781, 39782, 40553]

Re: Review Request 40553: Enable mesos tests installation.

2016-01-27 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/ --- (Updated Jan. 27, 2016, 5:54 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 40553: Enable mesos tests installation.

2016-01-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#review116608 --- Patch looks great! Reviews applied: [39780, 39781, 39782, 40553]

Re: Review Request 40553: Enable mesos tests installation.

2016-01-27 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#review116610 --- Looks mostly good to me. A few things were unclear to me: *

Re: Review Request 40553: Enable mesos tests installation.

2016-01-27 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/ --- (Updated Jan. 27, 2016, 9:03 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 40553: Enable mesos tests installation.

2016-01-27 Thread James Peach
> On Jan. 27, 2016, 7:44 p.m., Benjamin Bannier wrote: > > Looks mostly good to me. A few things were unclear to me: > > > > * Would it make sense to add an `installcheck` target? My expectation for > > that would be for it to invoke the installed tests and adding the > > (in)correct

Re: Review Request 40553: Enable mesos tests installation.

2016-01-26 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#review116385 --- Could you please rebase? This doesn't apply for me with

Re: Review Request 40553: Enable mesos tests installation.

2016-01-22 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/ --- (Updated Jan. 22, 2016, 10:12 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 40553: Enable mesos tests installation

2016-01-22 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/ --- (Updated Jan. 22, 2016, 10:03 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 40553: Enable mesos tests installation.

2016-01-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#review115974 --- Patch looks great! Reviews applied: [39780, 39781, 39782, 40553]

Re: Review Request 40553: Enable mesos tests installation

2016-01-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#review114851 --- Bad patch! Reviews applied: [39780, 39781, 39782, 40553] Failed

Re: Review Request 40553: Enable mesos tests installation.

2016-01-16 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/ --- (Updated Jan. 16, 2016, 5:41 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 40553: Enable mesos tests installation.

2016-01-15 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/ --- (Updated Jan. 15, 2016, 6:44 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 40553: Enable mesos tests installation.

2016-01-15 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/ --- (Updated Jan. 15, 2016, 8:17 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 40553: Enable mesos tests installation

2016-01-15 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/ --- (Updated Jan. 16, 2016, 5:53 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 40553: Enable mesos tests installation.

2016-01-12 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/ --- (Updated Jan. 13, 2016, 4:06 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 40553: Enable mesos tests installation

2016-01-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#review114144 --- Bad patch! Reviews applied: [39780, 39781, 39782, 40553] Failed

Re: Review Request 40553: Enable mesos tests installation

2016-01-12 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/ --- (Updated Jan. 12, 2016, 10:50 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 40553: Enable mesos tests installation

2015-12-17 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/ --- (Updated Dec. 17, 2015, 5:43 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 40553: Enable mesos tests installation

2015-12-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#review111076 --- Patch looks great! Reviews applied: [39780, 39781, 39782, 40553]

Re: Review Request 40553: Enable mesos tests installation

2015-12-10 Thread James Peach
> On Dec. 10, 2015, 3:30 p.m., Till Toenshoff wrote: > > src/tests/utils.cpp, lines 71-77 > > > > > > I still don't understand why the oversubscription tests need to have > > this installed in the LIBDIR and not in

Re: Review Request 40553: Enable mesos tests installation

2015-12-10 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/ --- (Updated Dec. 10, 2015, 9:28 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 40553: Enable mesos tests installation

2015-12-10 Thread Benjamin Bannier
> On Nov. 25, 2015, 2:36 p.m., Benjamin Bannier wrote: > > src/tests/containerizer/memory_test_helper.cpp, line 197 > > > > > > Should probably be passed as an arg (`bool` or even better an `enum` > > value). You

Re: Review Request 40553: Enable mesos tests installation

2015-12-10 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#review107994 --- Great work James, much appreciated. And yes, it is tedious and

Re: Review Request 40553: Enable mesos tests installation

2015-11-30 Thread James Peach
> On Nov. 25, 2015, 2:36 p.m., Benjamin Bannier wrote: > > src/Makefile.am, line 1753 > > > > > > This would be a perfect opportunity to add a config header, and not > > pass any more strings as command line

Re: Review Request 40553: Enable mesos tests installation

2015-11-30 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/ --- (Updated Nov. 30, 2015, 6:43 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 40553: Enable mesos tests installation

2015-11-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#review107988 --- configure.ac (line 245)

Re: Review Request 40553: Enable mesos tests installation

2015-11-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40553/#review107429 --- Patch looks great! Reviews applied: [39780, 39781, 39782, 40553]