Re: Review Request 40563: Added functionality for handling status updates from HTTP based executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40563/#review107673 --- Ship it! src/slave/slave.cpp (line 3039)

Re: Review Request 40563: Added functionality for handling status updates from HTTP based executors

> On Nov. 23, 2015, 11:38 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, line 3040 > > > > > > backticks for `statusUpdate()` ? There are multiple occurences in the present file that don't use backticks for

Re: Review Request 40563: Added functionality for handling status updates from HTTP based executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40563/#review107489 --- Patch looks great! Reviews applied: [40560, 40561, 40562, 40570,

Re: Review Request 40563: Added functionality for handling status updates from HTTP based executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40563/ --- (Updated Nov. 21, 2015, 12:21 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 40563: Added functionality for handling status updates from HTTP based executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40563/#review107452 --- src/slave/http.cpp (lines 318 - 322)

Re: Review Request 40563: Added functionality for handling status updates from HTTP based executors

> On Nov. 21, 2015, 12:58 a.m., Vinod Kone wrote: > > src/slave/http.cpp, lines 318-322 > > > > > > indent by 4 spaces. > > > > also, it's hard to tell that None() is the argument for statusUpdate() > >

Re: Review Request 40563: Added functionality for handling status updates from HTTP based executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40563/ --- (Updated Nov. 21, 2015, 1:45 a.m.) Review request for mesos, Ben Mahler,