Re: Review Request 40618: Include the header for boost::hash_combine explicitly

2015-12-01 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40618/#review108561
---

Ship it!


Ship It!

- Vinod Kone


On Nov. 23, 2015, 10:42 p.m., Cong Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40618/
> ---
> 
> (Updated Nov. 23, 2015, 10:42 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently boost/functional/hash.hpp is included implicitly, we should include 
> it explicitly.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
> bffdc3829208496ef14fecca497af73d4399867b 
> 
> Diff: https://reviews.apache.org/r/40618/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Cong Wang
> 
>



Re: Review Request 40618: Include the header for boost::hash_combine explicitly

2015-11-23 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40618/#review107699
---


Patch looks great!

Reviews applied: [40618]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 23, 2015, 10:42 p.m., Cong Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40618/
> ---
> 
> (Updated Nov. 23, 2015, 10:42 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently boost/functional/hash.hpp is included implicitly, we should include 
> it explicitly.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 
> bffdc3829208496ef14fecca497af73d4399867b 
> 
> Diff: https://reviews.apache.org/r/40618/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Cong Wang
> 
>