Re: Review Request 40631: Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"

2015-12-04 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40631/#review108953 --- Ship it! Ship It! - Michael Park On Dec. 4, 2015, 7:11 a.m.,

Re: Review Request 40631: Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"

2015-12-03 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40631/ --- (Updated Dec. 4, 2015, 3:11 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 40631: Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"

2015-12-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40631/#review108534 --- Patch looks great! Reviews applied: [40631] Passed command:

Re: Review Request 40631: Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"

2015-12-01 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40631/ --- (Updated Dec. 1, 2015, 8:51 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 40631: Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"

2015-12-01 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40631/#review108487 --- src/slave/containerizer/fetcher.hpp (line 41)

Re: Review Request 40631: Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"

2015-12-01 Thread Klaus Ma
> On Nov. 24, 2015, 5:42 p.m., Benjamin Bannier wrote: > > src/tests/mesos.hpp, line 87 > > > > > > This seems like a weird addition for this patch: while the existing > > `using` decls above could be justified

Re: Review Request 40631: Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"

2015-12-01 Thread Klaus Ma
> On Dec. 1, 2015, 9:08 p.m., Michael Park wrote: > > src/slave/containerizer/fetcher.hpp, line 43 > > > > > > I agree with the intent to remove the using declaration out of > > `fetcher.hpp`, but I don't agree with

Re: Review Request 40631: Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"

2015-11-29 Thread Benjamin Bannier
> On Nov. 24, 2015, 9:42 a.m., Benjamin Bannier wrote: > > src/tests/mesos.hpp, line 87 > > > > > > This seems like a weird addition for this patch: while the existing > > `using` decls above could be justified

Re: Review Request 40631: Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"

2015-11-29 Thread Michael Park
> On Nov. 24, 2015, 9:42 a.m., Benjamin Bannier wrote: > > src/tests/mesos.hpp, line 87 > > > > > > This seems like a weird addition for this patch: while the existing > > `using` decls above could be justified

Re: Review Request 40631: Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"

2015-11-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40631/#review108045 --- Patch looks great! Reviews applied: [40631] Passed command:

Re: Review Request 40631: Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"

2015-11-25 Thread Benjamin Bannier
> On Nov. 24, 2015, 9:42 a.m., Benjamin Bannier wrote: > > src/tests/mesos.hpp, line 87 > > > > > > This seems like a weird addition for this patch: while the existing > > `using` decls above could be justified

Re: Review Request 40631: Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"

2015-11-25 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40631/#review107962 --- Ship it! Ship It! - Benjamin Bannier On Nov. 25, 2015, 1:54

Re: Review Request 40631: Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"

2015-11-24 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40631/ --- (Updated Nov. 25, 2015, 9:54 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 40631: Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"

2015-11-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40631/#review107865 --- Patch looks great! Reviews applied: [40631] Passed command:

Re: Review Request 40631: Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"

2015-11-24 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40631/#review107742 --- src/tests/mesos.hpp (line 87)

Re: Review Request 40631: Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"

2015-11-24 Thread Klaus Ma
> On Nov. 24, 2015, 5:42 p.m., Benjamin Bannier wrote: > > src/tests/mesos.hpp, line 87 > > > > > > This seems like a weird addition for this patch: while the existing > > `using` decls above could be justified

Re: Review Request 40631: Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"

2015-11-24 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40631/#review107741 --- src/tests/mesos.hpp (line 87)