Re: Review Request 40700: Fixed signed vs. unsigned comparison in a test.

2015-11-25 Thread Till Toenshoff

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40700/#review107972
---

Ship it!


Ship It!

- Till Toenshoff


On Nov. 25, 2015, 11:29 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40700/
> ---
> 
> (Updated Nov. 25, 2015, 11:29 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-4009
> https://issues.apache.org/jira/browse/MESOS-4009
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> GCC 5.1 fails to compile if both types in ASSERT_EQ don't match.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 34d9762a70e906c656c29d1ae48cb0ee0004e60f 
> 
> Diff: https://reviews.apache.org/r/40700/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>



Re: Review Request 40700: Fixed signed vs. unsigned comparison in a test.

2015-11-25 Thread Jan Schlicht

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40700/
---

(Updated Nov. 25, 2015, 11:29 a.m.)


Review request for mesos, Benjamin Bannier, Till Toenshoff, and Timothy Chen.


Summary (updated)
-

Fixed signed vs. unsigned comparison in a test.


Bugs: MESOS-4009
https://issues.apache.org/jira/browse/MESOS-4009


Repository: mesos


Description
---

GCC 5.1 fails to compile if both types in ASSERT_EQ don't match.


Diffs
-

  src/tests/containerizer/provisioner_docker_tests.cpp 
34d9762a70e906c656c29d1ae48cb0ee0004e60f 

Diff: https://reviews.apache.org/r/40700/diff/


Testing
---

make check


Thanks,

Jan Schlicht