Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

2016-01-13 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/ --- (Updated Jan. 13, 2016, 3:43 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

2015-12-08 Thread Avinash sridharan
> On Dec. 2, 2015, 6:32 p.m., Bernd Mathiske wrote: > > src/tests/reservation_tests.cpp, line 248 > > > > > > More customary indentation: > > > > EXPECT_CALL(sched, resourceOffers(, _)) > >

Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

2015-12-02 Thread Bernd Mathiske
> On Nov. 30, 2015, 6:15 a.m., Bernd Mathiske wrote: > > src/tests/reservation_tests.cpp, line 248 > > > > > > s/RESERVE/UNRESERVE/ ? > > > > What is the intention here? Please explain. > > Avinash

Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

2015-12-02 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/#review108696 --- src/tests/reservation_tests.cpp (line 237)

Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

2015-12-02 Thread Avinash sridharan
> On Dec. 2, 2015, 6:32 p.m., Bernd Mathiske wrote: > > src/tests/reservation_tests.cpp, line 248 > > > > > > More customary indentation: > > > > EXPECT_CALL(sched, resourceOffers(, _)) > >

Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

2015-12-02 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/#review108704 --- Some minor comments modulo comments from Bernd earlier.

Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

2015-12-02 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/ --- (Updated Dec. 2, 2015, 8:23 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

2015-12-02 Thread Avinash sridharan
> On Nov. 30, 2015, 2:15 p.m., Bernd Mathiske wrote: > > src/tests/reservation_tests.cpp, line 176 > > > > > > Also see the indentations in various other statements involving > > argument passing, etc. Best to sit

Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

2015-12-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/#review108621 --- Bad patch! Reviews applied: [40730, 40732, 40731] Failed

Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

2015-12-02 Thread Avinash sridharan
> On Dec. 2, 2015, 8:02 p.m., Anand Mazumdar wrote: > > src/tests/reservation_tests.cpp, line 213 > > > > > > Is this comment needed ? I think this a copy-paste issue. This must have come from the previous test

Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

2015-12-02 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/ --- (Updated Dec. 2, 2015, 10:38 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

2015-12-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/#review108754 --- Bad patch! Reviews applied: [40730, 40732, 40731] Failed

Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

2015-11-30 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/#review108313 --- src/tests/reservation_tests.cpp (line 168)

Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

2015-11-30 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/ --- (Updated Nov. 30, 2015, 5:39 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40731: Adding the test framework submitted by Mandeep (@mchadha) https://reviews.apache.org/r/39056/

2015-11-26 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/#review108142 --- src/tests/reservation_tests.cpp (line 163)