Re: Review Request 40776: Fixed test flakiness in FetcherTest and FetcherCacheTest.

2015-12-03 Thread Benjamin Bannier 


> On Dec. 3, 2015, 1:05 p.m., Bernd Mathiske wrote:
> > src/tests/fetcher_tests.cpp, line 543
> > 
> >
> > Since both ExtractNotExecutable and ExtractTar dio the same now one of 
> > these tests is redundant and can be deleted. However, we are then no longer 
> > testing if the extension .tgz is recognized. How about changing one of the 
> > tests to using that extension (with a comment why) yet using 
> > non-compressing packaging. Unpacking will still work.

Note that at least the current `os::tar` and since 2013-03-13 *always did 
compress with gzip* regardless of the extension.

To still touch the path matching the `.tar.gz` extension (sic) I restored the 
old filename in `FetcherTest.ExtractNotExecutable`, but still created an 
uncompressed file to work around the issue here.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40776/#review108816
---


On Dec. 3, 2015, 2:33 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40776/
> ---
> 
> (Updated Dec. 3, 2015, 2:33 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Till Toenshoff.
> 
> 
> Bugs: MESOS-3579
> https://issues.apache.org/jira/browse/MESOS-3579
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> GNU tar-1.28 and earlier can relatively randomly misidentify
> compressed files as uncompressed ones, and will then fail when
> unpacking. Avoid compressed tar files in some tests where we know we
> directly call the tar system command (in mesos-fetcher in this case).
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp ac5ad6acfcf60b7094ec45f64bed164b4dc3f8bd 
>   src/tests/fetcher_tests.cpp 99c494a2167ea9ec94e63d92980df17a4089f95a 
> 
> Diff: https://reviews.apache.org/r/40776/diff/
> 
> 
> Testing
> ---
> 
> `make check` and verified test does not fail in at least 17500 iterations.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 40776: Fixed test flakiness in FetcherTest and FetcherCacheTest.

2015-12-03 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40776/
---

(Updated Dec. 3, 2015, 2:33 p.m.)


Review request for mesos, Bernd Mathiske and Till Toenshoff.


Changes
---

Added some variation in filename extension.

Also switched from `os::system` to `os::shell` so we can suppress benign stderr 
output from `tar` (`tar: Removing leading '/' from member names`).


Bugs: MESOS-3579
https://issues.apache.org/jira/browse/MESOS-3579


Repository: mesos


Description
---

GNU tar-1.28 and earlier can relatively randomly misidentify
compressed files as uncompressed ones, and will then fail when
unpacking. Avoid compressed tar files in some tests where we know we
directly call the tar system command (in mesos-fetcher in this case).


Diffs (updated)
-

  src/tests/fetcher_cache_tests.cpp ac5ad6acfcf60b7094ec45f64bed164b4dc3f8bd 
  src/tests/fetcher_tests.cpp 99c494a2167ea9ec94e63d92980df17a4089f95a 

Diff: https://reviews.apache.org/r/40776/diff/


Testing
---

`make check` and verified test does not fail in at least 17500 iterations.


Thanks,

Benjamin Bannier

Re: Review Request 40776: Fixed test flakiness in FetcherTest and FetcherCacheTest.

2015-12-03 Thread Bernd Mathiske 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40776/#review108816
---



src/tests/fetcher_tests.cpp (line 543)


Since both ExtractNotExecutable and ExtractTar dio the same now one of 
these tests is redundant and can be deleted. However, we are then no longer 
testing if the extension .tgz is recognized. How about changing one of the 
tests to using that extension (with a comment why) yet using non-compressing 
packaging. Unpacking will still work.


- Bernd Mathiske


On Nov. 28, 2015, 3:15 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40776/
> ---
> 
> (Updated Nov. 28, 2015, 3:15 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Till Toenshoff.
> 
> 
> Bugs: MESOS-3579
> https://issues.apache.org/jira/browse/MESOS-3579
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> GNU tar-1.28 and earlier can relatively randomly misidentify
> compressed files as uncompressed ones, and will then fail when
> unpacking. Avoid compressed tar files in some tests where we know we
> directly call the tar system command (in mesos-fetcher in this case).
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 7fa5e6a572a40dc1a531001fcee2a377d1c99309 
>   src/tests/fetcher_tests.cpp 99c494a2167ea9ec94e63d92980df17a4089f95a 
> 
> Diff: https://reviews.apache.org/r/40776/diff/
> 
> 
> Testing
> ---
> 
> `make check` and verified test does not fail in at least 17500 iterations.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 40776: Fixed test flakiness in FetcherTest and FetcherCacheTest.

2015-12-03 Thread Bernd Mathiske 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40776/#review108831
---

Ship it!


Ship It!

- Bernd Mathiske


On Dec. 3, 2015, 6:33 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40776/
> ---
> 
> (Updated Dec. 3, 2015, 6:33 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Till Toenshoff.
> 
> 
> Bugs: MESOS-3579
> https://issues.apache.org/jira/browse/MESOS-3579
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> GNU tar-1.28 and earlier can relatively randomly misidentify
> compressed files as uncompressed ones, and will then fail when
> unpacking. Avoid compressed tar files in some tests where we know we
> directly call the tar system command (in mesos-fetcher in this case).
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp ac5ad6acfcf60b7094ec45f64bed164b4dc3f8bd 
>   src/tests/fetcher_tests.cpp 99c494a2167ea9ec94e63d92980df17a4089f95a 
> 
> Diff: https://reviews.apache.org/r/40776/diff/
> 
> 
> Testing
> ---
> 
> `make check` and verified test does not fail in at least 17500 iterations.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 40776: Fixed test flakiness in FetcherTest and FetcherCacheTest.

2015-11-28 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40776/#review108257
---


Patch looks great!

Reviews applied: [40776]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 28, 2015, 11:15 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40776/
> ---
> 
> (Updated Nov. 28, 2015, 11:15 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Till Toenshoff.
> 
> 
> Bugs: MESOS-3579
> https://issues.apache.org/jira/browse/MESOS-3579
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> GNU tar-1.28 and earlier can relatively randomly misidentify
> compressed files as uncompressed ones, and will then fail when
> unpacking. Avoid compressed tar files in some tests where we know we
> directly call the tar system command (in mesos-fetcher in this case).
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 7fa5e6a572a40dc1a531001fcee2a377d1c99309 
>   src/tests/fetcher_tests.cpp 99c494a2167ea9ec94e63d92980df17a4089f95a 
> 
> Diff: https://reviews.apache.org/r/40776/diff/
> 
> 
> Testing
> ---
> 
> `make check` and verified test does not fail in at least 17500 iterations.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 40776: Fixed test flakiness in FetcherTest and FetcherCacheTest.

2015-11-28 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40776/
---

(Updated Nov. 28, 2015, 11:15 a.m.)


Review request for mesos, Bernd Mathiske and Till Toenshoff.


Changes
---

Added explicit mention of JIRA issue in comments.


Bugs: MESOS-3579
https://issues.apache.org/jira/browse/MESOS-3579


Repository: mesos


Description
---

GNU tar-1.28 and earlier can relatively randomly misidentify
compressed files as uncompressed ones, and will then fail when
unpacking. Avoid compressed tar files in some tests where we know we
directly call the tar system command (in mesos-fetcher in this case).


Diffs (updated)
-

  src/tests/fetcher_cache_tests.cpp 7fa5e6a572a40dc1a531001fcee2a377d1c99309 
  src/tests/fetcher_tests.cpp 99c494a2167ea9ec94e63d92980df17a4089f95a 

Diff: https://reviews.apache.org/r/40776/diff/


Testing (updated)
---

`make check` and verified test does not fail in at least 17500 iterations.


Thanks,

Benjamin Bannier

Re: Review Request 40776: Fixed test flakiness in FetcherTest and FetcherCacheTest.

2015-11-28 Thread Benjamin Bannier 


> On Nov. 27, 2015, 9:53 p.m., Till Toenshoff wrote:
> > src/tests/fetcher_cache_tests.cpp, lines 325-326
> > 
> >
> > Let's add a reference to the JIRA describing the issue in more detail 
> > -- here and also in those other two duplicates of this comment.
> > 
> > ```
> > // Create an uncompressed tar archive (See MESOS-).
> > ```

Done, went with `... (see ...`.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40776/#review108246
---


On Nov. 28, 2015, 11:15 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40776/
> ---
> 
> (Updated Nov. 28, 2015, 11:15 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Till Toenshoff.
> 
> 
> Bugs: MESOS-3579
> https://issues.apache.org/jira/browse/MESOS-3579
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> GNU tar-1.28 and earlier can relatively randomly misidentify
> compressed files as uncompressed ones, and will then fail when
> unpacking. Avoid compressed tar files in some tests where we know we
> directly call the tar system command (in mesos-fetcher in this case).
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 7fa5e6a572a40dc1a531001fcee2a377d1c99309 
>   src/tests/fetcher_tests.cpp 99c494a2167ea9ec94e63d92980df17a4089f95a 
> 
> Diff: https://reviews.apache.org/r/40776/diff/
> 
> 
> Testing
> ---
> 
> `make check` and verified test does not fail in at least 17500 iterations.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 40776: Fixed test flakiness in FetcherTest and FetcherCacheTest.

2015-11-27 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40776/
---

(Updated Nov. 27, 2015, 6:11 p.m.)


Review request for mesos, Bernd Mathiske and Till Toenshoff.


Bugs: MESOS-3579
https://issues.apache.org/jira/browse/MESOS-3579


Repository: mesos


Description
---

GNU tar-1.28 and earlier can relatively randomly misidentify
compressed files as uncompressed ones, and will then fail when
unpacking. Avoid compressed tar files in some tests where we know we
directly call the tar system command (in mesos-fetcher in this case).


Diffs
-

  src/tests/fetcher_cache_tests.cpp 7fa5e6a572a40dc1a531001fcee2a377d1c99309 
  src/tests/fetcher_tests.cpp 99c494a2167ea9ec94e63d92980df17a4089f95a 

Diff: https://reviews.apache.org/r/40776/diff/


Testing
---

`make check` and verified test does not fail in at least 1000 iterations.


Thanks,

Benjamin Bannier

Re: Review Request 40776: Fixed test flakiness in FetcherTest and FetcherCacheTest.

2015-11-27 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40776/#review108245
---


Patch looks great!

Reviews applied: [40776]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 27, 2015, 6:11 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40776/
> ---
> 
> (Updated Nov. 27, 2015, 6:11 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Till Toenshoff.
> 
> 
> Bugs: MESOS-3579
> https://issues.apache.org/jira/browse/MESOS-3579
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> GNU tar-1.28 and earlier can relatively randomly misidentify
> compressed files as uncompressed ones, and will then fail when
> unpacking. Avoid compressed tar files in some tests where we know we
> directly call the tar system command (in mesos-fetcher in this case).
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 7fa5e6a572a40dc1a531001fcee2a377d1c99309 
>   src/tests/fetcher_tests.cpp 99c494a2167ea9ec94e63d92980df17a4089f95a 
> 
> Diff: https://reviews.apache.org/r/40776/diff/
> 
> 
> Testing
> ---
> 
> `make check` and verified test does not fail in at least 1000 iterations.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 40776: Fixed test flakiness in FetcherTest and FetcherCacheTest.

2015-11-27 Thread Till Toenshoff 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40776/#review108246
---

Ship it!


Thanks for this Benjamin - really made sense to re-evaluate our options :).


src/tests/fetcher_cache_tests.cpp (lines 325 - 326)


Let's add a reference to the JIRA describing the issue in more detail -- 
here and also in those other two duplicates of this comment.

```
// Create an uncompressed tar archive (See MESOS-).
```


- Till Toenshoff


On Nov. 27, 2015, 6:11 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40776/
> ---
> 
> (Updated Nov. 27, 2015, 6:11 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Till Toenshoff.
> 
> 
> Bugs: MESOS-3579
> https://issues.apache.org/jira/browse/MESOS-3579
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> GNU tar-1.28 and earlier can relatively randomly misidentify
> compressed files as uncompressed ones, and will then fail when
> unpacking. Avoid compressed tar files in some tests where we know we
> directly call the tar system command (in mesos-fetcher in this case).
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 7fa5e6a572a40dc1a531001fcee2a377d1c99309 
>   src/tests/fetcher_tests.cpp 99c494a2167ea9ec94e63d92980df17a4089f95a 
> 
> Diff: https://reviews.apache.org/r/40776/diff/
> 
> 
> Testing
> ---
> 
> `make check` and verified test does not fail in at least 1000 iterations.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>