Re: Review Request 40872: Changed RegistryClientTest to use instance work directory.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40872/#review109713
---



src/tests/containerizer/provisioner_docker_tests.cpp (line 527)


Btw, we use camel case for method names.


- Timothy Chen


On Dec. 2, 2015, 4:23 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40872/
> ---
> 
> (Updated Dec. 2, 2015, 4:23 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-4025
> https://issues.apache.org/jira/browse/MESOS-4025
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> RegistryClientTest suite uses static variable for is work directory. This has
> been changed to model the TemporaryDirectoryTest suite.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> c63bf53fee40ef12536a16e11f4d5224c4e4278e 
> 
> Diff: https://reviews.apache.org/r/40872/diff/
> 
> 
> Testing
> ---
> 
> make check (600 times).
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 40872: Changed RegistryClientTest to use instance work directory.

[Timothy Chen]

> On Dec. 10, 2015, 8:37 a.m., Timothy Chen wrote:
> > src/tests/containerizer/provisioner_docker_tests.cpp, line 526
> > 
> >
> > How about just use os::getcwd? And why do we even need a uuid based 
> > working directory if tmp directory test creates a directory already?

For now I'll remove this and just use os::getcwd as I don't really see it being 
necessary.


- Timothy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40872/#review109709
---


On Dec. 2, 2015, 4:23 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40872/
> ---
> 
> (Updated Dec. 2, 2015, 4:23 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-4025
> https://issues.apache.org/jira/browse/MESOS-4025
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> RegistryClientTest suite uses static variable for is work directory. This has
> been changed to model the TemporaryDirectoryTest suite.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> c63bf53fee40ef12536a16e11f4d5224c4e4278e 
> 
> Diff: https://reviews.apache.org/r/40872/diff/
> 
> 
> Testing
> ---
> 
> make check (600 times).
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 40872: Changed RegistryClientTest to use instance work directory.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40872/#review109709
---



src/tests/containerizer/provisioner_docker_tests.cpp (line 526)


How about just use os::getcwd? And why do we even need a uuid based working 
directory if tmp directory test creates a directory already?


- Timothy Chen


On Dec. 2, 2015, 4:23 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40872/
> ---
> 
> (Updated Dec. 2, 2015, 4:23 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-4025
> https://issues.apache.org/jira/browse/MESOS-4025
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> RegistryClientTest suite uses static variable for is work directory. This has
> been changed to model the TemporaryDirectoryTest suite.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> c63bf53fee40ef12536a16e11f4d5224c4e4278e 
> 
> Diff: https://reviews.apache.org/r/40872/diff/
> 
> 
> Testing
> ---
> 
> make check (600 times).
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 40872: Changed RegistryClientTest to use instance work directory.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40872/#review109759
---

Ship it!


Ship It!

- Timothy Chen


On Dec. 2, 2015, 4:23 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40872/
> ---
> 
> (Updated Dec. 2, 2015, 4:23 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-4025
> https://issues.apache.org/jira/browse/MESOS-4025
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> RegistryClientTest suite uses static variable for is work directory. This has
> been changed to model the TemporaryDirectoryTest suite.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> c63bf53fee40ef12536a16e11f4d5224c4e4278e 
> 
> Diff: https://reviews.apache.org/r/40872/diff/
> 
> 
> Testing
> ---
> 
> make check (600 times).
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>