Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40951/#review109559
---



src/CMakeLists.txt (lines 223 - 226)


Actually, I think I should have been more diligent about reviewing 
carefully here.

I think that this might make more sense down when we set `MESOS_SRC` with 
all the other variables listed here.

Per our conversation, I think your intuition that we really want to append 
this to `AGENT_SRC` is actually totally right, but my counterpoint is that we 
actually want the `AGENT_SRC` to include a bunch of these other source groups 
anyway, so appending to the `AGENT_SRC` really doesn't have too many advantages 
in my view.


- Alex Clemmer


On Dec. 9, 2015, 3:45 a.m., Diana Arroyo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40951/
> ---
> 
> (Updated Dec. 9, 2015, 3:45 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3843
> https://issues.apache.org/jira/browse/MESOS-3843
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Initial set of source files missing for cmake agent binary.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef 
> 
> Diff: https://reviews.apache.org/r/40951/diff/
> 
> 
> Testing
> ---
> 
> Tested to make sure library builds successfully.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40951/#review109562
---



src/CMakeLists.txt (lines 267 - 286)


Sorry, one more thing. :)

The definition of `MESOS_SRC` is split up by these two definitions. Do you 
think it makes more sense to not split up this definition by putting this block 
of code somewhere else?


- Alex Clemmer


On Dec. 9, 2015, 3:45 a.m., Diana Arroyo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40951/
> ---
> 
> (Updated Dec. 9, 2015, 3:45 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3843
> https://issues.apache.org/jira/browse/MESOS-3843
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Initial set of source files missing for cmake agent binary.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef 
> 
> Diff: https://reviews.apache.org/r/40951/diff/
> 
> 
> Testing
> ---
> 
> Tested to make sure library builds successfully.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

[Diana Arroyo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40951/
---

(Updated Dec. 9, 2015, 9:15 p.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, and Joseph Wu.


Changes
---

Merge later review r41104 into this review.


Bugs: MESOS-3843
https://issues.apache.org/jira/browse/MESOS-3843


Repository: mesos


Description
---

Initial set of source files missing for cmake agent binary.


Diffs (updated)
-

  src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef 

Diff: https://reviews.apache.org/r/40951/diff/


Testing
---

Tested to make sure library builds successfully.


Thanks,

Diana Arroyo

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

[Diana Arroyo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40951/
---

(Updated Dec. 9, 2015, 10:48 p.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, and Joseph Wu.


Bugs: MESOS-3843
https://issues.apache.org/jira/browse/MESOS-3843


Repository: mesos


Description
---

Initial set of source files missing for cmake agent binary.


Diffs (updated)
-

  src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef 

Diff: https://reviews.apache.org/r/40951/diff/


Testing
---

Tested to make sure library builds successfully.


Thanks,

Diana Arroyo

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40951/#review109620
---

Ship it!


Ship It!

- Alex Clemmer


On Dec. 9, 2015, 10:48 p.m., Diana Arroyo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40951/
> ---
> 
> (Updated Dec. 9, 2015, 10:48 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3843
> https://issues.apache.org/jira/browse/MESOS-3843
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Initial set of source files missing for cmake agent binary.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef 
> 
> Diff: https://reviews.apache.org/r/40951/diff/
> 
> 
> Testing
> ---
> 
> Tested to make sure library builds successfully.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

[Diana Arroyo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40951/
---

(Updated Dec. 8, 2015, 3:59 p.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, and Joseph Wu.


Bugs: MESOS-3843
https://issues.apache.org/jira/browse/MESOS-3843


Repository: mesos


Description
---

Initial set of source files missing for cmake agent binary.


Diffs (updated)
-

  src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef 

Diff: https://reviews.apache.org/r/40951/diff/


Testing
---

Tested to make sure library builds successfully.


Thanks,

Diana Arroyo

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40951/#review109446
---

Ship it!


Ship It!

- Joseph Wu


On Dec. 8, 2015, 7:59 a.m., Diana Arroyo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40951/
> ---
> 
> (Updated Dec. 8, 2015, 7:59 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3843
> https://issues.apache.org/jira/browse/MESOS-3843
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Initial set of source files missing for cmake agent binary.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef 
> 
> Diff: https://reviews.apache.org/r/40951/diff/
> 
> 
> Testing
> ---
> 
> Tested to make sure library builds successfully.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

[Diana Arroyo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40951/
---

(Updated Dec. 9, 2015, 3:45 a.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, and Joseph Wu.


Bugs: MESOS-3843
https://issues.apache.org/jira/browse/MESOS-3843


Repository: mesos


Description
---

Initial set of source files missing for cmake agent binary.


Diffs (updated)
-

  src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef 

Diff: https://reviews.apache.org/r/40951/diff/


Testing
---

Tested to make sure library builds successfully.


Thanks,

Diana Arroyo

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40951/#review109206
---

Ship it!



src/CMakeLists.txt (line 222)


Perhaps there should be a blank line above this block?



src/CMakeLists.txt (lines 224 - 227)


Our list style is: if a list append can fit on one line, we usually try to 
fit it.



src/CMakeLists.txt (line 269)


Our style is: we don't put a space between `set` and `(`.



src/CMakeLists.txt (lines 274 - 280)


Hmm, I might be crazy, but does `isolators` come before `linux_launcher`? :)



src/CMakeLists.txt (line 289)


There's an extra newline here.


- Alex Clemmer


On Dec. 5, 2015, 3:35 a.m., Diana Arroyo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40951/
> ---
> 
> (Updated Dec. 5, 2015, 3:35 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3843
> https://issues.apache.org/jira/browse/MESOS-3843
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Initial set of source files missing for cmake agent binary.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef 
> 
> Diff: https://reviews.apache.org/r/40951/diff/
> 
> 
> Testing
> ---
> 
> Tested to make sure library builds successfully.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

[Diana Arroyo]

> On Dec. 4, 2015, 9:48 p.m., Joseph Wu wrote:
> > Diana, can you add `hausdorff`, `kaysoky`, `hartem`, and `jvanremoortere` 
> > to this review (and future CMake reviews)?
> > 
> > ---
> > 
> > Ran `cmake .. && make` on OSX.  Hit this error:
> > ```
> > mesos/src/slave/containerizer/mesos/linux_launcher.cpp:20:10: fatal error: 
> > 'linux/sched.h' file not found
> > #include 
> > ```
> > 
> > Note that `src/Makefile.am` does this:
> > ```
> > if OS_LINUX
> > libmesos_no_3rdparty_la_SOURCES += $(MESOS_LINUX_FILES)
> > else
> > EXTRA_DIST += $(MESOS_LINUX_FILES)
> > endif
> > ```
> > And `linux_launcher.cpp` is in `MESOS_LINUX_FILES`.

Reference: "can you add hausdorff, kaysoky, hartem, and jvanremoortere to this 
review (and future CMake reviews)?":  Done.
Reference: "fatal error: 'linux/sched.h' file not found": working...


- Diana


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40951/#review109032
---


On Dec. 4, 2015, 6:30 p.m., Diana Arroyo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40951/
> ---
> 
> (Updated Dec. 4, 2015, 6:30 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3843
> https://issues.apache.org/jira/browse/MESOS-3843
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Initial set of source files missing for cmake agent binary.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef 
> 
> Diff: https://reviews.apache.org/r/40951/diff/
> 
> 
> Testing
> ---
> 
> Tested to make sure library builds successfully.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40951/#review109032
---


Diana, can you add `hausdorff`, `kaysoky`, `hartem`, and `jvanremoortere` to 
this review (and future CMake reviews)?

---

Ran `cmake .. && make` on OSX.  Hit this error:
```
mesos/src/slave/containerizer/mesos/linux_launcher.cpp:20:10: fatal error: 
'linux/sched.h' file not found
#include 
```

Note that `src/Makefile.am` does this:
```
if OS_LINUX
libmesos_no_3rdparty_la_SOURCES += $(MESOS_LINUX_FILES)
else
EXTRA_DIST += $(MESOS_LINUX_FILES)
endif
```
And `linux_launcher.cpp` is in `MESOS_LINUX_FILES`.

- Joseph Wu


On Dec. 4, 2015, 10:30 a.m., Diana Arroyo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40951/
> ---
> 
> (Updated Dec. 4, 2015, 10:30 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3843
> https://issues.apache.org/jira/browse/MESOS-3843
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Initial set of source files missing for cmake agent binary.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef 
> 
> Diff: https://reviews.apache.org/r/40951/diff/
> 
> 
> Testing
> ---
> 
> Tested to make sure library builds successfully.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

[Diana Arroyo]

> On Dec. 4, 2015, 9:48 p.m., Joseph Wu wrote:
> > Diana, can you add `hausdorff`, `kaysoky`, `hartem`, and `jvanremoortere` 
> > to this review (and future CMake reviews)?
> > 
> > ---
> > 
> > Ran `cmake .. && make` on OSX.  Hit this error:
> > ```
> > mesos/src/slave/containerizer/mesos/linux_launcher.cpp:20:10: fatal error: 
> > 'linux/sched.h' file not found
> > #include 
> > ```
> > 
> > Note that `src/Makefile.am` does this:
> > ```
> > if OS_LINUX
> > libmesos_no_3rdparty_la_SOURCES += $(MESOS_LINUX_FILES)
> > else
> > EXTRA_DIST += $(MESOS_LINUX_FILES)
> > endif
> > ```
> > And `linux_launcher.cpp` is in `MESOS_LINUX_FILES`.
> 
> Diana Arroyo wrote:
> Reference: "can you add hausdorff, kaysoky, hartem, and jvanremoortere to 
> this review (and future CMake reviews)?":  Done.
> Reference: "fatal error: 'linux/sched.h' file not found": working...

Reference: "fatal error: 'linux/sched.h' file not found": Fixed.


- Diana


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40951/#review109032
---


On Dec. 5, 2015, 3:35 a.m., Diana Arroyo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40951/
> ---
> 
> (Updated Dec. 5, 2015, 3:35 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3843
> https://issues.apache.org/jira/browse/MESOS-3843
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Initial set of source files missing for cmake agent binary.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef 
> 
> Diff: https://reviews.apache.org/r/40951/diff/
> 
> 
> Testing
> ---
> 
> Tested to make sure library builds successfully.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

[Diana Arroyo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40951/
---

(Updated Dec. 5, 2015, 3:35 a.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, and Joseph Wu.


Bugs: MESOS-3843
https://issues.apache.org/jira/browse/MESOS-3843


Repository: mesos


Description
---

Initial set of source files missing for cmake agent binary.


Diffs (updated)
-

  src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef 

Diff: https://reviews.apache.org/r/40951/diff/


Testing
---

Tested to make sure library builds successfully.


Thanks,

Diana Arroyo

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40951/#review109082
---


Patch looks great!

Reviews applied: [40951]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 5, 2015, 3:35 a.m., Diana Arroyo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40951/
> ---
> 
> (Updated Dec. 5, 2015, 3:35 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3843
> https://issues.apache.org/jira/browse/MESOS-3843
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Initial set of source files missing for cmake agent binary.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef 
> 
> Diff: https://reviews.apache.org/r/40951/diff/
> 
> 
> Testing
> ---
> 
> Tested to make sure library builds successfully.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 40951: Initial set of source files missing for cmake agent binary.

[Diana Arroyo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40951/
---

(Updated Dec. 4, 2015, 6:30 p.m.)


Review request for mesos.


Bugs: MESOS-3843
https://issues.apache.org/jira/browse/MESOS-3843


Repository: mesos


Description
---

Initial set of source files missing for cmake agent binary.


Diffs
-

  src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef 

Diff: https://reviews.apache.org/r/40951/diff/


Testing
---

Tested to make sure library builds successfully.


Thanks,

Diana Arroyo