Re: Review Request 40978: Modify the Http test process in FetcherTests to be symmetric in spawn/terminate.

2015-12-09 Thread Bernd Mathiske
> On Dec. 9, 2015, 2:31 a.m., Benjamin Bannier wrote: > > src/tests/fetcher_tests.cpp, line 278 > > > > > > Unneeded dead code which should be removed (otherwise should be `= > > default`). You are right, but all o

Re: Review Request 40978: Modify the Http test process in FetcherTests to be symmetric in spawn/terminate.

2015-12-09 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40978/#review109492 --- src/tests/fetcher_tests.cpp (line 278)

Re: Review Request 40978: Modify the Http test process in FetcherTests to be symmetric in spawn/terminate.

2015-12-09 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40978/#review109486 --- Ship it! src/tests/fetcher_tests.cpp (line 278)

Re: Review Request 40978: Modify the Http test process in FetcherTests to be symmetric in spawn/terminate.

2015-12-09 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40978/#review109485 --- Ship it! Ship It! - Michael Park On Dec. 4, 2015, 6:49 p.m., Jo

Re: Review Request 40978: Modify the Http test process in FetcherTests to be symmetric in spawn/terminate.

2015-12-09 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40978/#review109483 --- Ship it! This looks a lot like other HTTP tests now. Good job repl

Re: Review Request 40978: Modify the Http test process in FetcherTests to be symmetric in spawn/terminate.

2015-12-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40978/#review109021 --- Patch looks great! Reviews applied: [40978] Passed command: expor