Re: Review Request 41096: CMake: Added LFLAGs need for linux cmake build

2015-12-10 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41096/#review109804
---

Ship it!


Ship It!

- Joris Van Remoortere


On Dec. 10, 2015, 3:16 a.m., Diana Arroyo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41096/
> ---
> 
> (Updated Dec. 10, 2015, 3:16 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3843
> https://issues.apache.org/jira/browse/MESOS-3843
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
> a9cd9902567cef4c7ab4125463a68e19907db0b4 
> 
> Diff: https://reviews.apache.org/r/41096/diff/
> 
> 
> Testing
> ---
> 
> Tested on Ubuntu and OSX.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>



Re: Review Request 41096: CMake: Added LFLAGs need for linux cmake build

2015-12-10 Thread Alex Clemmer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41096/#review109768
---



3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake (line 97)


So the `curl` flag was here for Windows but not for Linux.

Does this work for you without this flag, by the way? Just curious. We 
should still add it (and in fact, I should have added it some time ago).


- Alex Clemmer


On Dec. 10, 2015, 3:16 a.m., Diana Arroyo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41096/
> ---
> 
> (Updated Dec. 10, 2015, 3:16 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3843
> https://issues.apache.org/jira/browse/MESOS-3843
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
> a9cd9902567cef4c7ab4125463a68e19907db0b4 
> 
> Diff: https://reviews.apache.org/r/41096/diff/
> 
> 
> Testing
> ---
> 
> Tested on Ubuntu and OSX.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>



Re: Review Request 41096: CMake: Added LFLAGs need for linux cmake build

2015-12-09 Thread Diana Arroyo

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41096/
---

(Updated Dec. 10, 2015, 3:16 a.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, and Joseph Wu.


Changes
---

Added AGENT target definition.


Summary (updated)
-

CMake: Added LFLAGs need for linux cmake build


Bugs: MESOS-3843
https://issues.apache.org/jira/browse/MESOS-3843


Repository: mesos


Description (updated)
---

See summary.


Diffs (updated)
-

  3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
a9cd9902567cef4c7ab4125463a68e19907db0b4 

Diff: https://reviews.apache.org/r/41096/diff/


Testing
---

Tested on Ubuntu and OSX.


Thanks,

Diana Arroyo