Re: Review Request 41167: Logger Module: Add support for the ContainerLogger to the Mesos Containerizer.

2015-12-29 Thread Benjamin Hindman
> On Dec. 29, 2015, 7:29 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 807-810 > > > > > > Flying by. We try to avoid huge nested lambda functions. Can you pull > > the continuation

Re: Review Request 41167: Logger Module: Add support for the ContainerLogger to the Mesos Containerizer.

2015-12-29 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41167/#review112248 --- Ship it! I'll make the change below and commit.

Re: Review Request 41167: Logger Module: Add support for the ContainerLogger to the Mesos Containerizer.

2015-12-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41167/#review112204 --- src/slave/containerizer/mesos/containerizer.cpp (lines 807 - 810)

Re: Review Request 41167: Logger Module: Add support for the ContainerLogger to the Mesos Containerizer.

2015-12-29 Thread Joseph Wu
> On Dec. 29, 2015, 11:29 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 807-810 > > > > > > Flying by. We try to avoid huge nested lambda functions. Can you pull > > the

Re: Review Request 41167: Logger Module: Add support for the ContainerLogger to the Mesos Containerizer.

2015-12-21 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41167/ --- (Updated Dec. 21, 2015, 11:37 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41167: Logger Module: Add support for the ContainerLogger to the Mesos Containerizer.

2015-12-21 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41167/ --- (Updated Dec. 21, 2015, 5:21 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41167: Logger Module: Add support for the ContainerLogger to the Mesos Containerizer.

2015-12-20 Thread Benjamin Hindman
> On Dec. 14, 2015, 9:21 p.m., Jie Yu wrote: > > src/slave/main.cpp, lines 227-245 > > > > > > I am wondering why logger has to be injected, instead of being owned by > > containerizer? Let containerizer owning the

Re: Review Request 41167: Logger Module: Add support for the ContainerLogger to the Mesos Containerizer.

2015-12-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41167/ --- (Updated Dec. 15, 2015, 12:40 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41167: Logger Module: Add support for the ContainerLogger to the Mesos Containerizer.

2015-12-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41167/ --- (Updated Dec. 14, 2015, 3:47 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41167: Logger Module: Add support for the ContainerLogger to the Mesos Containerizer.

2015-12-14 Thread Joseph Wu
> On Dec. 14, 2015, 1:21 p.m., Jie Yu wrote: > > src/slave/main.cpp, lines 227-245 > > > > > > I am wondering why logger has to be injected, instead of being owned by > > containerizer? Let containerizer owning the

Re: Review Request 41167: Logger Module: Add support for the ContainerLogger to the Mesos Containerizer.

2015-12-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41167/#review110308 --- src/slave/main.cpp (lines 227 - 245)

Re: Review Request 41167: Logger Module: Add support for the ContainerLogger to the Mesos Containerizer.

2015-12-11 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41167/ --- (Updated Dec. 11, 2015, 4:39 p.m.) Review request for mesos, Benjamin Hindman