Re: Review Request 41188: Providing JSON bindings to expose DiscoveryInfo protobuf messages to HTTP endpoints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41188/ --- (Updated Dec. 17, 2015, 7:51 p.m.) Review request for mesos, Adam B and Anand

Re: Review Request 41188: Providing JSON bindings to expose DiscoveryInfo protobuf messages to HTTP endpoints

> On Dec. 17, 2015, 12:12 a.m., Anand Mazumdar wrote: > > src/tests/common/http_tests.cpp, lines 130-140 > > > > > > Can you confirm that other objects that have labels that are exposed > > via `/state` endpoint

Re: Review Request 41188: Providing JSON bindings to expose DiscoveryInfo protobuf messages to HTTP endpoints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41188/ --- (Updated Dec. 17, 2015, 10:40 p.m.) Review request for mesos, Adam B and Anand

Re: Review Request 41188: Providing JSON bindings to expose DiscoveryInfo protobuf messages to HTTP endpoints

> On Dec. 17, 2015, 10:47 a.m., Adam B wrote: > > src/tests/slave_tests.cpp, lines -2224 > > > > > > Doesn't this all fit on one 80-char line? > > > > Also, it looks like we have a

Re: Review Request 41188: Providing JSON bindings to expose DiscoveryInfo protobuf messages to HTTP endpoints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41188/#review11 --- Patch looks great! Reviews applied: [41187, 41188] Passed

Re: Review Request 41188: Providing JSON bindings to expose DiscoveryInfo protobuf messages to HTTP endpoints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41188/#review05 --- Ship it! Minor correction+suggestion. Ready to commit once you're