Re: Review Request 41223: Cleaned up creation of HTTP auth headers in tests.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41223/#review110099
---

Ship it!



src/tests/mesos.hpp (lines 539 - 542)


The indentation here changed.



src/tests/mesos.hpp (line 1189)


I'm going to pull this out in to a separate typo fix for you.


- Joris Van Remoortere


On Dec. 10, 2015, 9:46 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41223/
> ---
> 
> (Updated Dec. 10, 2015, 9:46 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Cleaned up creation of HTTP auth headers in tests.
> 
> 
> Diffs
> -
> 
>   src/tests/master_quota_tests.cpp 12820fcf7c0d2a791071464ad8ed738664ad85de 
>   src/tests/mesos.hpp 2429ac5cbcd9c1a3949c11de94b542108a3c13d8 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 0a03b5f1ac7dec14bd99c31768f86100f2b60616 
>   src/tests/reservation_endpoints_tests.cpp 
> d5d2aa7c203aa7357b564ff51cd3b38230195d04 
> 
> Diff: https://reviews.apache.org/r/41223/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 41223: Cleaned up creation of HTTP auth headers in tests.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41223/#review109898
---


Patch looks great!

Reviews applied: [41223]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 10, 2015, 9:46 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41223/
> ---
> 
> (Updated Dec. 10, 2015, 9:46 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Cleaned up creation of HTTP auth headers in tests.
> 
> 
> Diffs
> -
> 
>   src/tests/master_quota_tests.cpp 12820fcf7c0d2a791071464ad8ed738664ad85de 
>   src/tests/mesos.hpp 2429ac5cbcd9c1a3949c11de94b542108a3c13d8 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> 0a03b5f1ac7dec14bd99c31768f86100f2b60616 
>   src/tests/reservation_endpoints_tests.cpp 
> d5d2aa7c203aa7357b564ff51cd3b38230195d04 
> 
> Diff: https://reviews.apache.org/r/41223/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>