Re: Review Request 41364: Add NOTE to Examples in Getting Started for prod

2015-12-14 Thread Guangya Liu
> On Dec. 15, 2015, 12:51 a.m., Guangya Liu wrote: > > Another two comments here: > > 1) It is recommended to use past tense in your summary. eg, s/Add/Added > > 2) Add a period to the end of your summary. > > Kevin Klues wrote: > Even if it goes over the 70 characters for the git summary?

Re: Review Request 41364: Add NOTE to Examples in Getting Started for prod

2015-12-14 Thread Kevin Klues
> On Dec. 15, 2015, 12:51 a.m., Guangya Liu wrote: > > Another two comments here: > > 1) It is recommended to use past tense in your summary. eg, s/Add/Added > > 2) Add a period to the end of your summary. > > Kevin Klues wrote: > Even if it goes over the 70 characters for the git summary?

Re: Review Request 41364: Add NOTE to Examples in Getting Started for prod

2015-12-14 Thread Guangya Liu
> On Dec. 15, 2015, 12:51 a.m., Guangya Liu wrote: > > Another two comments here: > > 1) It is recommended to use past tense in your summary. eg, s/Add/Added > > 2) Add a period to the end of your summary. > > Kevin Klues wrote: > Even if it goes over the 70 characters for the git summary?

Re: Review Request 41364: Add NOTE to Examples in Getting Started for prod

2015-12-14 Thread Kevin Klues
> On Dec. 15, 2015, 12:51 a.m., Guangya Liu wrote: > > Another two comments here: > > 1) It is recommended to use past tense in your summary. eg, s/Add/Added > > 2) Add a period to the end of your summary. > > Kevin Klues wrote: > Even if it goes over the 70 characters for the git summary?

Re: Review Request 41364: Add NOTE to Examples in Getting Started for prod

2015-12-14 Thread Kevin Klues
> On Dec. 15, 2015, 12:51 a.m., Guangya Liu wrote: > > Another two comments here: > > 1) It is recommended to use past tense in your summary. eg, s/Add/Added > > 2) Add a period to the end of your summary. Even if it goes over the 70 characters for the git summary? Or should I reword to stay u

Re: Review Request 41364: Add NOTE to Examples in Getting Started for prod

2015-12-14 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41364/#review110353 --- Another two comments here: 1) It is recommended to use past tense i

Re: Review Request 41364: Add NOTE to Examples in Getting Started for prod

2015-12-14 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41364/ --- (Updated Dec. 15, 2015, 12:44 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 41364: Add NOTE to Examples in Getting Started for prod

2015-12-14 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41364/#review110351 --- The description needs a little update as following: s/why they can