Re: Review Request 41364: Add NOTE to Examples in Getting Started for prod
> On Dec. 15, 2015, 12:51 a.m., Guangya Liu wrote: > > Another two comments here: > > 1) It is recommended to use past tense in your summary. eg, s/Add/Added > > 2) Add a period to the end of your summary. > > Kevin Klues wrote: > Even if it goes over the 70 characters for the git summary? Or should I > reword to stay under the limit? > > Kevin Klues wrote: > I meant 50 character limit > > Guangya Liu wrote: > I think that the commit summary do not have such limit. Please check > https://reviews.apache.org/dashboard/?group=mesos&view=to-group to view all > of the patches and there is actually no limit, but no limit does not mean it > can be very long ;-) > > Kevin Klues wrote: > Sure, not on reviewboard, but the recommended summary line in a git > commit is 50 characters or less (so that git tools can parse it and display > it properly). I always write my summaries to stay within this limit. Just some of my experience: Sometimes I found that the commit message was not updated in review board when I "git commit --amend", so I often chage the summary directly in review board. - Guangya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41364/#review110353 --- On Dec. 15, 2015, 12:44 a.m., Kevin Klues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41364/ > --- > > (Updated Dec. 15, 2015, 12:44 a.m.) > > > Review request for mesos, Benjamin Hindman and Neil Conway. > > > Bugs: MESOS-3844 > https://issues.apache.org/jira/browse/MESOS-3844 > > > Repository: mesos > > > Description > --- > > The current instructions assume you are launching mesos on your local > machine. This could be confusing for someone trying to run mesos on > (e.g. AWS) and not understanding why they can't access the mesos > web page. This note adds a comment to try and hinder such confusion. > > > Diffs > - > > docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb > > Diff: https://reviews.apache.org/r/41364/diff/ > > > Testing > --- > > > Thanks, > > Kevin Klues > >
Re: Review Request 41364: Add NOTE to Examples in Getting Started for prod
> On Dec. 15, 2015, 12:51 a.m., Guangya Liu wrote: > > Another two comments here: > > 1) It is recommended to use past tense in your summary. eg, s/Add/Added > > 2) Add a period to the end of your summary. > > Kevin Klues wrote: > Even if it goes over the 70 characters for the git summary? Or should I > reword to stay under the limit? > > Kevin Klues wrote: > I meant 50 character limit > > Guangya Liu wrote: > I think that the commit summary do not have such limit. Please check > https://reviews.apache.org/dashboard/?group=mesos&view=to-group to view all > of the patches and there is actually no limit, but no limit does not mean it > can be very long ;-) Sure, not on reviewboard, but the recommended summary line in a git commit is 50 characters or less (so that git tools can parse it and display it properly). I always write my summaries to stay within this limit. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41364/#review110353 --- On Dec. 15, 2015, 12:44 a.m., Kevin Klues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41364/ > --- > > (Updated Dec. 15, 2015, 12:44 a.m.) > > > Review request for mesos, Benjamin Hindman and Neil Conway. > > > Bugs: MESOS-3844 > https://issues.apache.org/jira/browse/MESOS-3844 > > > Repository: mesos > > > Description > --- > > The current instructions assume you are launching mesos on your local > machine. This could be confusing for someone trying to run mesos on > (e.g. AWS) and not understanding why they can't access the mesos > web page. This note adds a comment to try and hinder such confusion. > > > Diffs > - > > docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb > > Diff: https://reviews.apache.org/r/41364/diff/ > > > Testing > --- > > > Thanks, > > Kevin Klues > >
Re: Review Request 41364: Add NOTE to Examples in Getting Started for prod
> On Dec. 15, 2015, 12:51 a.m., Guangya Liu wrote: > > Another two comments here: > > 1) It is recommended to use past tense in your summary. eg, s/Add/Added > > 2) Add a period to the end of your summary. > > Kevin Klues wrote: > Even if it goes over the 70 characters for the git summary? Or should I > reword to stay under the limit? > > Kevin Klues wrote: > I meant 50 character limit I think that the commit summary do not have such limit. Please check https://reviews.apache.org/dashboard/?group=mesos&view=to-group to view all of the patches and there is actually no limit, but no limit does not mean it can be very long ;-) - Guangya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41364/#review110353 --- On Dec. 15, 2015, 12:44 a.m., Kevin Klues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41364/ > --- > > (Updated Dec. 15, 2015, 12:44 a.m.) > > > Review request for mesos, Benjamin Hindman and Neil Conway. > > > Bugs: MESOS-3844 > https://issues.apache.org/jira/browse/MESOS-3844 > > > Repository: mesos > > > Description > --- > > The current instructions assume you are launching mesos on your local > machine. This could be confusing for someone trying to run mesos on > (e.g. AWS) and not understanding why they can't access the mesos > web page. This note adds a comment to try and hinder such confusion. > > > Diffs > - > > docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb > > Diff: https://reviews.apache.org/r/41364/diff/ > > > Testing > --- > > > Thanks, > > Kevin Klues > >
Re: Review Request 41364: Add NOTE to Examples in Getting Started for prod
> On Dec. 15, 2015, 12:51 a.m., Guangya Liu wrote: > > Another two comments here: > > 1) It is recommended to use past tense in your summary. eg, s/Add/Added > > 2) Add a period to the end of your summary. > > Kevin Klues wrote: > Even if it goes over the 70 characters for the git summary? Or should I > reword to stay under the limit? I meant 50 character limit - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41364/#review110353 --- On Dec. 15, 2015, 12:44 a.m., Kevin Klues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41364/ > --- > > (Updated Dec. 15, 2015, 12:44 a.m.) > > > Review request for mesos, Benjamin Hindman and Neil Conway. > > > Bugs: MESOS-3844 > https://issues.apache.org/jira/browse/MESOS-3844 > > > Repository: mesos > > > Description > --- > > The current instructions assume you are launching mesos on your local > machine. This could be confusing for someone trying to run mesos on > (e.g. AWS) and not understanding why they can't access the mesos > web page. This note adds a comment to try and hinder such confusion. > > > Diffs > - > > docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb > > Diff: https://reviews.apache.org/r/41364/diff/ > > > Testing > --- > > > Thanks, > > Kevin Klues > >
Re: Review Request 41364: Add NOTE to Examples in Getting Started for prod
> On Dec. 15, 2015, 12:51 a.m., Guangya Liu wrote: > > Another two comments here: > > 1) It is recommended to use past tense in your summary. eg, s/Add/Added > > 2) Add a period to the end of your summary. Even if it goes over the 70 characters for the git summary? Or should I reword to stay under the limit? - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41364/#review110353 --- On Dec. 15, 2015, 12:44 a.m., Kevin Klues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41364/ > --- > > (Updated Dec. 15, 2015, 12:44 a.m.) > > > Review request for mesos, Benjamin Hindman and Neil Conway. > > > Bugs: MESOS-3844 > https://issues.apache.org/jira/browse/MESOS-3844 > > > Repository: mesos > > > Description > --- > > The current instructions assume you are launching mesos on your local > machine. This could be confusing for someone trying to run mesos on > (e.g. AWS) and not understanding why they can't access the mesos > web page. This note adds a comment to try and hinder such confusion. > > > Diffs > - > > docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb > > Diff: https://reviews.apache.org/r/41364/diff/ > > > Testing > --- > > > Thanks, > > Kevin Klues > >
Re: Review Request 41364: Add NOTE to Examples in Getting Started for prod
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41364/#review110353 --- Another two comments here: 1) It is recommended to use past tense in your summary. eg, s/Add/Added 2) Add a period to the end of your summary. - Guangya Liu On Dec. 15, 2015, 12:44 a.m., Kevin Klues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41364/ > --- > > (Updated Dec. 15, 2015, 12:44 a.m.) > > > Review request for mesos, Benjamin Hindman and Neil Conway. > > > Bugs: MESOS-3844 > https://issues.apache.org/jira/browse/MESOS-3844 > > > Repository: mesos > > > Description > --- > > The current instructions assume you are launching mesos on your local > machine. This could be confusing for someone trying to run mesos on > (e.g. AWS) and not understanding why they can't access the mesos > web page. This note adds a comment to try and hinder such confusion. > > > Diffs > - > > docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb > > Diff: https://reviews.apache.org/r/41364/diff/ > > > Testing > --- > > > Thanks, > > Kevin Klues > >
Re: Review Request 41364: Add NOTE to Examples in Getting Started for prod
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41364/ --- (Updated Dec. 15, 2015, 12:44 a.m.) Review request for mesos, Benjamin Hindman and Neil Conway. Bugs: MESOS-3844 https://issues.apache.org/jira/browse/MESOS-3844 Repository: mesos Description (updated) --- The current instructions assume you are launching mesos on your local machine. This could be confusing for someone trying to run mesos on (e.g. AWS) and not understanding why they can't access the mesos web page. This note adds a comment to try and hinder such confusion. Diffs (updated) - docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb Diff: https://reviews.apache.org/r/41364/diff/ Testing --- Thanks, Kevin Klues
Re: Review Request 41364: Add NOTE to Examples in Getting Started for prod
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41364/#review110351 --- The description needs a little update as following: s/why they can get access to the mesos/why they can NOT get access to the mesos - Guangya Liu On Dec. 14, 2015, 8:40 p.m., Kevin Klues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41364/ > --- > > (Updated Dec. 14, 2015, 8:40 p.m.) > > > Review request for mesos, Benjamin Hindman and Neil Conway. > > > Bugs: MESOS-3844 > https://issues.apache.org/jira/browse/MESOS-3844 > > > Repository: mesos > > > Description > --- > > The current instructions assume you are launching mesos on your local > machine. this could be confusing for someone trying to run mesos on > (e.g. AWS) and not understanding why they can get access to the mesos > web page. This note adds a comment to try and hinder such confusion. > > > Diffs > - > > docs/getting-started.md 0225c9db985261b9c3057b2b376f29b1c80784fb > > Diff: https://reviews.apache.org/r/41364/diff/ > > > Testing > --- > > > Thanks, > > Kevin Klues > >
