Re: Review Request 41370: Logger Module: Update DockerContainerizer test helpers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41370/#review112256 --- Ship it! Ship It! - Benjamin Hindman On Dec. 22, 2015, 1:35 a.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41370/ > --- > > (Updated Dec. 22, 2015, 1:35 a.m.) > > > Review request for mesos, Benjamin Hindman and Artem Harutyunyan. > > > Bugs: MESOS-4137 > https://issues.apache.org/jira/browse/MESOS-4137 > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > src/tests/mesos.hpp 582b018ea0e41cb2a9cdbf8cd1cf46870179757b > src/tests/mesos.cpp 11ca0519ad0dad44328b6ebdf52c5356fda818b7 > > Diff: https://reviews.apache.org/r/41370/diff/ > > > Testing > --- > > Tests will be modified and run later in the review chain. > > > Thanks, > > Joseph Wu > >
Re: Review Request 41370: Logger Module: Update DockerContainerizer test helpers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41370/ --- (Updated Dec. 21, 2015, 5:35 p.m.) Review request for mesos, Benjamin Hindman and Artem Harutyunyan. Changes --- Remove `ContainerLogger` injection from the `Docker` class. Bugs: MESOS-4137 https://issues.apache.org/jira/browse/MESOS-4137 Repository: mesos Description --- See summary. Diffs (updated) - src/tests/mesos.hpp 582b018ea0e41cb2a9cdbf8cd1cf46870179757b src/tests/mesos.cpp 11ca0519ad0dad44328b6ebdf52c5356fda818b7 Diff: https://reviews.apache.org/r/41370/diff/ Testing --- Tests will be modified and run later in the review chain. Thanks, Joseph Wu
Re: Review Request 41370: Logger Module: Update DockerContainerizer test helpers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41370/#review111432 --- Again, this looks mechanical given https://reviews.apache.org/r/41294 but please see comments there. - Benjamin Hindman On Dec. 15, 2015, 2:14 a.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41370/ > --- > > (Updated Dec. 15, 2015, 2:14 a.m.) > > > Review request for mesos, Benjamin Hindman and Artem Harutyunyan. > > > Bugs: MESOS-4137 > https://issues.apache.org/jira/browse/MESOS-4137 > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > src/tests/mesos.hpp 689efb40dc22337766b624218d2504d5de3e5cd8 > src/tests/mesos.cpp a501f04dfbf9c93c2196e83b512519e925a67c97 > > Diff: https://reviews.apache.org/r/41370/diff/ > > > Testing > --- > > Tests will be modified and run later in the review chain. > > > Thanks, > > Joseph Wu > >
Re: Review Request 41370: Logger Module: Update DockerContainerizer test helpers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41370/#review110397 --- Ship it! Ship It! - Timothy Chen On Dec. 15, 2015, 2:14 a.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41370/ > --- > > (Updated Dec. 15, 2015, 2:14 a.m.) > > > Review request for mesos, Benjamin Hindman and Artem Harutyunyan. > > > Bugs: MESOS-4137 > https://issues.apache.org/jira/browse/MESOS-4137 > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > src/tests/mesos.hpp 689efb40dc22337766b624218d2504d5de3e5cd8 > src/tests/mesos.cpp a501f04dfbf9c93c2196e83b512519e925a67c97 > > Diff: https://reviews.apache.org/r/41370/diff/ > > > Testing > --- > > Tests will be modified and run later in the review chain. > > > Thanks, > > Joseph Wu > >
